Don't raise HTTPStatusErrors on CORS errors when querying packages in a transaction - #225
Conversation
|
@ryanking13, is this what you had in mind? |
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
@ryanking13, is this what you had in mind?
Yes, exactly. I think you can remove HttpStatusError from the compatibility code as it is not imported anymore.
Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
for more information, see https://pre-commit.ci
|
Okay, done! I have to say this is a part of |
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
Left a minor comment. Otherwise looks good. Thanks!
|
@agriyakhetarpal Is this okay to merge? I would like to make a micropip release before the Pyodide release. |
|
Hi @ryanking13, yes, this is okay to merge. I was mostly waiting for you here, in case you had any more comments :D I also added some feedback for the Anaconda.org team regarding CORS errors on HTTP exceptions in scientific-python/upload-nightly-action#130 (which is also shown above), and I linked this PR to serve additional context. |
|
I see. Sorry to make you wait! There is a test failure but I believe it is not related to this PR. merging. |
agriyakhetarpal
changed the title
HTTPStatusError on CORS errors when querying packages in a transactionHTTPStatusErrors on CORS errors when querying packages in a transaction
2 participants
Description
See #223; this PR changes the behaviour to not stop at CORS errors when querying an index. This should serve as a temporary respite when installing from indices that don't add CORS headers for 404s and the like, such as Anaconda.org. Please also see scientific-python/upload-nightly-action#130 for additional context.