MAINT Inject compat layer to Transaction - #213
Conversation
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @ryanking13! The code changes LGTM. Could you please elaborate on the (immediate) further ideas after this PR? If I understand correctly, the idea in this PR has been to isolate the transactions better, based on the environment micropip is running in. I apologise that this PR has gone stale, in case your plans evade your memory!
| *, | ||
| # TODO: instead of passing this as a parameter, it should be a class attribute | ||
| compat_layer: type[CompatibilityLayer], |
There was a problem hiding this comment.
I agree with the comment. Could you please open a issue to track it?
There was a problem hiding this comment.
Thanks. I opened an issue to track the progress (#237). Not just for this comment but for overall refactoring for the compatibility layer.
|
Thanks for the question @agriyakhetarpal! The goal for these PRs is to remove the global compatibility layer and make it a dependency of the
|
|
Thanks for the explanation! That makes sense to me. |
Related: #112
Another PR that removes direct
._compatimport from child classes and functions. No functional changes are included.