FIX Respect yanked flag - #208
Conversation
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @ryanking13! I have just a few comments, the code looks good to me. Again, thanks for the reminder on Discord.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @ryanking13! This looks great now.
I do wonder if Codecov is helping us, as you previously mentioned a few days ago somewhere (I can't find that comment) that it misses a few lines that are actually covered, as it can't run the tests in a WASM environment. For example, it reports that YANKED_WARNING_MESSAGE in line 244 of micropip/transaction.py was not covered, but it's definitely there in the test_integration_install_yanked case you added,
Nevertheless, maybe we can find a way to run coverage.py in a WASM environment and use the HTML/Markdown reports it can generate, as I don't think sys.monitoring needs any special attention in Pyodide. (Of course, not for this PR).
Yes, I think running coverage inside WASM is not that hard. The hard part would be merging the results of the coverage.py inside and outside Pyodide. |
|
Thanks for the review! |
Resolve: #146
Updates the resolver to respect
yankedflag (PEP-592).If the version with the yanked flag set is found, it will be considered as a last resort, when all other versions are incompatible.