Skip to content

Add support for extra variants of relative urls for simple html pypi API #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanking13 merged 4 commits into from
Jan 21, 2025
Merged

Add support for extra variants of relative urls for simple html pypi API #174

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af29453
Add support for extra variants of relative urls for simple html pypi API
artem-samokhin Jan 20, 2025
0846677
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 20, 2025
ca062ec
changelog & code review
artem-samokhin Jan 20, 2025
df8dfc6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions micropip/package_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from dataclasses import dataclass
from functools import partial
from typing import Any
from urllib.parse import urlparse, urlunparse
from urllib.parse import urljoin, urlparse, urlunparse

from packaging.utils import InvalidWheelFilename
from packaging.version import InvalidVersion, Version
Expand Down Expand Up @@ -130,8 +130,10 @@ def _parse_pep691_response(
version = parse_version(filename)
except (InvalidVersion, InvalidWheelFilename):
continue
if file["url"].startswith("/"):
file["url"] = index_base_url + file["url"]

is_absolute_url = bool(urlparse(file["url"]).netloc)
if not is_absolute_url:
file["url"] = urljoin(index_base_url, file["url"])

releases[version].append(file)

Expand Down
17 changes: 17 additions & 0 deletions tests/test_data/pypi_response/fake-pkg-micropip-test_simple.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!DOCTYPE html>
<html>
<head>
<meta name="pypi:repository-version" content="1.1">
<title>Links for fake-pkg-micropip-test</title>

@ryanking13 ryanking13 Jan 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the filename? So the readers can easily know that it is for testing the relative url.

@artem-samokhin artem-samokhin Jan 20, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks, I've updated changelog (I assume I have to put my changes under Unreleased section) and renamed new fixtures file.

</head>
<body>
<h1>Links for fake-pkg-micropip-test</h1>
<a href="../../packages/fake-pkg-micropip-test/1.0.0/fake_pkg_micropip_test-1.0.0.tar.gz#sha256=aed8c5ebf0320f526d1550f1754afa69ebc20855224fc5a02a3d74fababd9fa4" data-requires-python="&gt;=3.6">fake_pkg_micropip_test-1.0.0.tar.gz</a>
<a href="../../packages/fake-pkg-micropip-test/1.0.0/fake_pkg_micropip_test-1.0.0-py3-none-any.whl#sha256=f4a7ba72e93bc97ff491b66d69063819ae2b75238bb653cd4c95e3f2847ce76e" data-requires-python="&gt;=3.6">fake_pkg_micropip_test-1.0.0-py3-none-any.whl</a>
<a href="../packages/fake-pkg-micropip-test/1.1.0/fake_pkg_micropip_test-1.1.0.tar.gz#sha256=bed8c5ebf0320f526d1550f1754afa69ebc20855224fc5a02a3d74fababd9fa5" data-requires-python="&gt;=3.6">fake_pkg_micropip_test-1.1.0.tar.gz</a>
<a href="../packages/fake-pkg-micropip-test/1.1.0/fake_pkg_micropip_test-1.1.0-py3-none-any.whl#sha256=c8e1716e83cc398ae16824e5572ae04e0d9fc2c6b985fb0f900f5f0c96ecba1a" data-requires-python="&gt;=3.6">fake_pkg_micropip_test-1.1.0-py3-none-any.whl</a>
<a href="./packages/fake-pkg-micropip-test/1.2.0/fake_pkg_micropip_test-1.2.0-py3-none-any.whl#sha256=d8e1716e83cc398ae16824e5572ae04e0d9fc2c6b985fb0f900f5f0c96ecba1b" data-requires-python="&gt;=3.6">fake_pkg_micropip_test-1.2.0-py3-none-any.whl</a>
<a href="/packages/fake-pkg-micropip-test/1.3.0/fake_pkg_micropip_test-1.3.0-py3-none-any.whl#sha256=e8e1716e83cc398ae16824e5572ae04e0d9fc2c6b985fb0f900f5f0c96ecba1c" data-requires-python="&gt;=3.6">fake_pkg_micropip_test-1.3.0-py3-none-any.whl</a>
<a href="packages/fake-pkg-micropip-test/1.4.0/fake_pkg_micropip_test-1.4.0-py3-none-any.whl#sha256=f8e1716e83cc398ae16824e5572ae04e0d9fc2c6b985fb0f900f5f0c96ecba1d" data-requires-python="&gt;=3.6">fake_pkg_micropip_test-1.4.0-py3-none-any.whl</a>
</body>
</html>
3 changes: 2 additions & 1 deletion tests/test_package_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ def test_project_info_from_simple_json(name):


@pytest.mark.parametrize(
"name", ["numpy", "black", "pytest", "snowballstemmer", "pytz"]
"name",
["numpy", "black", "pytest", "snowballstemmer", "pytz", "fake-pkg-micropip-test"],
)
def test_project_info_from_simple_html(name):
test_file = TEST_PYPI_RESPONSE_DIR / f"{name}_simple.html"
Expand Down