Update to beta release of pyyaml for #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @cmonr |
flit
approved these changes
Jan 15, 2019
|
Of course, you create this PR just after I release v0.15.0! 😁 |
|
Btw, pyyaml is currently at version 4.2b4. |
|
Truth be told, I don't like that we had to pin pyyaml to a beta version, and am not sure what the difference between the two is. I'd be alright with updating it if there's a good reason, otherwise I think we'll be waiting for the next non-beta release :) |
|
Oops, sorry for the bad timing!! |
We need to be better with requirements and have it fixed asap, this is the second this week for us 😕 |
|
@cmonr Once the final pyyaml 4.2 is released, we'll update the dependency. I'm not fond of pinning to a beta version either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2017-18342 has been issued. Mbed OS also now pins this dependency: https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt#L7. This is causing some issues in their CI, so I'm proposing this change here. Happy to discuss alternatives if you feel any are appropriate!