Skip to content

Add an implementation of broadcast for xtensor #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: labeled_tensors
Choose a base branch
from
Open

Add an implementation of broadcast for xtensor #1486

wants to merge 19 commits into from

Conversation

AllenDowney
Copy link
Contributor

@AllenDowney AllenDowney commented Jun 19, 2025 •
edited by github-actions bot
Loading

ricardoV94 and others added 18 commits June 6, 2025 11:28
@ricardoV94
Use DimShuffle instead of Reshape in ix_
1625444
@ricardoV94
Don't lose static shape in AdvancedIncSubtensor
60811aa
@ricardoV94
Basic labeled tensor functionality
d1caa8c
@ricardoV94
Implement stack for XTensorVariables
fd49cfd
@ricardoV94
Implement Elemwise and Blockwise operations for XTensorVariables
1be8711
@ricardoV94
Implement cast for XTensorVariables
5a863f9
@ricardoV94
Implement reduction operations for XTensorVariables
88e3f1e
@ricardoV94
Implement concat for XTensorVariables
e370812
@AllenDowney @ricardoV94
Implement transpose for XTensorVariables
13c415f
@OriolAbril @ricardoV94
Implement unstack for XTensorVariables
17d644d
@ricardoV94
Implement index for XTensorVariables
699c980
@ricardoV94
Implement index update for XTensorVariables
2ca8212
@ricardoV94
Implement diff for XTensorVariables
2032767
@AllenDowney @ricardoV94
Implement squeeze for XTensorVariables
7b8877b
@AllenDowney
Implement expand_dims for XTensorVariables (pymc-devs#1449)
f134792
@AllenDowney @ricardoV94
First cut at finishing off squeeze
3635db0
@AllenDowney
Implement dot for XTensorVariables (pymc-devs#1475)
b326b3d
@AllenDowney
Draft APIs
6b3ce34
@AllenDowney
Copy link
Contributor Author

@ricardoV94 This is just a starting place, mostly to sketch the APIs. Don't even look at the implementations yet.

This one is a little confusing to me because broadcast is a function in xarray but not a method. So I'm not sure how to map that onto the init and make_node methods of XOp.

Please take a look at this and then maybe we can talk through it synchronously.

@ricardoV94
Copy link
Member

There's also broadcast_like which is a method, but in general it doesn't matter if it's a method or a function, the strategy is usually the same

ricardoV94
ricardoV94 reviewed Jun 20, 2025
View reviewed changes
@ricardoV94 ricardoV94 force-pushed the labeled_tensors branch 5 times, most recently from 51031fc to 91b159b Compare June 20, 2025 17:02
@ricardoV94 ricardoV94 force-pushed the labeled_tensors branch 3 times, most recently from e3c5850 to 64c96af Compare June 20, 2025 17:24
@AllenDowney AllenDowney mentioned this pull request Jun 20, 2025
Open
@ricardoV94 ricardoV94 force-pushed the labeled_tensors branch 4 times, most recently from 71bc4ef to 41d9be4 Compare June 21, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllenDowney @ricardoV94 @OriolAbril