Do not fail with zero-sized arrays in dataset_to_point_list
#7856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
dataset_to_point_list
Numpy does not support reshape(-1, ...) when size is zero
ricardoV94
force-pushed
the
zero_size_dataset
branch
from
1719ce7 to
5ecc420
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7856 +/- ##
==========================================
+ Coverage 89.25% 92.98% +3.73%
==========================================
Files 108 108
Lines 18327 18328 +1
==========================================
+ Hits 16358 17043 +685
+ Misses 1969 1285 -684
🚀 New features to boost your workflow:
|
OriolAbril
approved these changes
Jul 17, 2025
| num_sample_dims = len(sample_dims) | ||
| stacked_dims = {dim_name: ds[var_names[0]][dim_name] for dim_name in sample_dims} | ||
| transposed_dict = {vn: da.transpose(*sample_dims, ...) for vn, da in ds.items()} | ||
| stacked_size = np.prod(transposed_dict[var_names[0]].shape[:num_sample_dims], dtype=int) |
There was a problem hiding this comment.
should be the same as
stacked_size = np.prod([ds.sizes[dim] for dim in sample_dims], dtype=int)
feel free to choose whichever you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy does not support reshape(-1, ...) when size is zero
📚 Documentation preview 📚: https://pymc--7856.org.readthedocs.build/en/7856/