Skip to content

implement _display_ method for pm.Model for builtin marimo support #7830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented Jun 23, 2025

Description

Marimo notebooks use the _display_ method to render objects in their notebooks. This adds a _display_ method to pm.Model

Reference:

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7830.org.readthedocs.build/en/7830/

@williambdean
Copy link
Contributor Author

Example usage in marimo:

Screenshot 2025-06-23 at 11 54 08 AM

@williambdean williambdean changed the title implement _display_ method for model implement _display_ method for pm.Model for builtin marimo support Jun 23, 2025
@williambdean
Copy link
Contributor Author

williambdean commented Jun 23, 2025

Any thoughts on this @ericmjl since you were involved here: marimo-team/marimo#4203

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (f4bdc6c) to head (02ffb7e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pymc/model/core.py 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7830      +/-   ##
==========================================
- Coverage   92.92%   92.91%   -0.01%     
==========================================
  Files         107      107              
  Lines       18279    18282       +3     
==========================================
+ Hits        16986    16987       +1     
- Misses       1293     1295       +2     
Files with missing lines Coverage Δ
pymc/model/core.py 93.48% <50.00%> (-0.25%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all-in on this one!

@ericmjl ericmjl merged commit 4271195 into pymc-devs:main Jun 24, 2025
26 checks passed
@williambdean williambdean deleted the marimo-display branch June 24, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants