Skip to content

Conversation

@OriolAbril
Copy link
Member

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #5224 (1cf20b1) into main (99ec0ff) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5224      +/-   ##
==========================================
+ Coverage   78.94%   78.97%   +0.03%     
==========================================
  Files          88       88              
  Lines       14248    14270      +22     
==========================================
+ Hits        11248    11270      +22     
  Misses       3000     3000              
Impacted Files Coverage Δ
pymc/distributions/continuous.py 96.60% <0.00%> (+0.02%) ⬆️
pymc/distributions/multivariate.py 71.91% <0.00%> (+0.56%) ⬆️

Copy link
Contributor

@martinacantaro martinacantaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a comment on a minor detail, it can be merged nonetheless so I'll give it a day or two and then merge even if that's not solved :)

Tags can be anything, but we ask you to try to use [existing tags](https://github.com/pymc-devs/pymc/wiki/Categories-and-Tags-for-PyMC-Examples) to avoid the tag list from getting too long. Each notebook should
have a single category indicating the level of the notebook. Choose a category from [existing categories](https://github.com/pymc-devs/pymc/wiki/Categories-and-Tags-for-PyMC-Examples#categories).
The [MyST target](https://myst-parser.readthedocs.io/en/latest/syntax/syntax.html#targets-and-cross-referencing)
is important to ease referencing and linking notebooks between them.
Copy link
Contributor

@martinacantaro martinacantaro Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is important to ease referencing and linking notebooks between them.
is important to ease referencing and linking notebooks between each other.

Maybe linking notebooks between each other is a better expression than linking notebooks between them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinacantaro I took the liberty of converting your comment into a suggestion to make it easier to update

@OriolAbril OriolAbril merged commit 01ed358 into main Nov 27, 2021
@OriolAbril OriolAbril deleted the minor_doc_fixes branch November 27, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants