Description
Description of your problem
set_data seems to have a problem when the new coordinates are nodes without an owner.
Please provide a minimal, self-contained, and reproducible example.
import numpy as np
import pymc as pm
with pm.Model() as m:
m.add_coord("a", np.arange(10), mutable=True)
pm.MutableData("x", np.zeros(10), dims="a")
m.set_data("x", np.ones(5), coords={"a": np.arange(10, 15)})Please provide the full traceback.
Complete error traceback
AttributeError Traceback (most recent call last)
<ipython-input-1-dc6231ed80dd> in <module>
7 pm.MutableData("x", np.zeros(10), dims="a")
8
----> 9 m.set_data("x", np.ones(5), coords={"a": np.arange(10, 15)})
~/repos/pymc3/pymc/model.py in set_data(self, name, values, coords)
1172 )
1173 else:
-> 1174 length_belongs_to = length_tensor.owner.inputs[0].owner.inputs[0]
1175 if not isinstance(length_belongs_to, SharedVariable):
1176 raise ShapeError(
AttributeError: 'NoneType' object has no attribute 'inputs'Please provide any additional information below.
In the traceback, length_tensor is m.dim_lengths["a"]. The type of this variable is aesara.tensor.sharedvar.ScalarSharedVariable and it has no owners. I don't know when the owner logic was introduced, but it doesn't cover the simple case where the new coordinate is an array. Maybe this was intended? In any case, this should be fixed before releasing v4
Original code
Originally, I was running on an older version with respect to main. The code that I used was this
import numpy as np
import pymc as pm
coords = {"a": np.arange(10)}
with pm.Model(coords=coords) as m:
pm.MutableData("x", np.zeros(10), dims="a")
m.set_data("x", np.ones(5), coords={"a": np.arange(10, 15)})Which now leads to the following traceback instead
ShapeError Traceback (most recent call last)
<ipython-input-2-d7c5b13f43a6> in <module>
7 pm.MutableData("x", np.zeros(10), dims="a")
8
----> 9 m.set_data("x", np.ones(5), coords={"a": np.arange(10, 15)})
~/repos/pymc3/pymc/model.py in set_data(self, name, values, coords)
1164 )
1165 if isinstance(length_tensor, TensorConstant):
-> 1166 raise ShapeError(
1167 f"Resizing dimension '{dname}' is impossible, because "
1168 "a 'TensorConstant' stores its length. To be able "
ShapeError: Resizing dimension 'a' is impossible, because a 'TensorConstant' stores its length. To be able to change the dimension length, pass `mutable=True` when registering the dimension via `model.add_coord`, or define it via a `pm.MutableData` variable.I think that it's rather strange not to be able to modify coordinates given via a constant tensor, but to be honest I didn't see when/where it was discussed.
Versions and main components
- PyMC/PyMC3 Version: 4.0.0b6
- Aesara/Theano Version:
- Python Version:
- Operating system:
- How did you install PyMC/PyMC3: (conda/pip)