-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Handle deferred evaluation of annotations in Python 3.14 #10381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should wait until we can test 3.14 in CI before merging this. I also don't really like that we need to duplicate a lot of tests. Maybe we can come up with a better solution for dealing conditional errors in our tests. |
This comment has been minimized.
This comment has been minimized.
Great !
Agree, so it's Blocked by pylint-dev/astroid#2731 and then the pylint equivalent.
Maybe time to design something to be able to expect something different according to the version ? something = 1 # [unused-variable|>=3.13,missing-module-docstring] With |
32635df
to
8615074
Compare
Explored something like this in #10382. The diff here would look much better, see 379ab07. |
8615074
to
379ab07
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but blocked by preliminary MRs.
379ab07
to
d452621
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10381 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 176 176
Lines 19155 19165 +10
=======================================
+ Hits 18363 18373 +10
Misses 792 792
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
d452621
to
e359cb9
Compare
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit e359cb9 |
This PR would is ready now. Even without 3.14 in CI yet, this could be helpful to move #10467 forward. Tested the functional tests locally with 3.14.0rc1. The remaining issues are unrelated to the changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice ! Let's merge before the 3.14 PR as you said.
Closes #10149