Respect docstring-min-length in docparams extension #10104

berkersal · 2024-12-02T14:30:13Z

Even though visit_functiondef is checking for docstring-min-length, it is not enough. This commit fixes the issue by adding the same check to visit_raise and visit_yield

If there is a better way of implementing this, please go forward. I am just providing a working fix to this problem.

Type of Changes

	Type
✓	🐛 Bug fix

Description

Refs #XXXX

Closes #XXXX

codecov · 2024-12-02T14:52:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (2f9af7d) to head (d1ad30d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10104   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         176      176           
  Lines       19137    19145    +8     
=======================================
+ Hits        18347    18355    +8     
  Misses        790      790

Files with missing lines	Coverage Δ
pylint/extensions/docparams.py	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pierre-Sassoulas

Thank you for opening a PR ! Would you mind adding functional tests (https://github.com/pylint-dev/pylint/tree/main/tests/functional/ext/docparams) and a changelog (https://github.com/pylint-dev/pylint/tree/main/doc/whatsnew/fragments) for this please ?

Pierre-Sassoulas

Looks good thank you ! Any reasons not to create a reusable function for the new code in the doc param class (copy pasted thrice as far as I understand) ?

Pierre-Sassoulas · 2024-12-07T14:35:12Z

Don't mind the fail of the CI this is due to python/cpython#125415 in 3.13.1 we're going to be able to rebase on main once it's fixed.

berkersal · 2024-12-07T16:15:48Z

Sorry for a lot of pushes 😅

berkersal · 2025-01-03T12:03:34Z

Something not related to my changes is giving an error on pre-commit checks

Pierre-Sassoulas · 2025-01-03T15:41:04Z

Sorry about that it's going to be fixed in #10165

pylint/extensions/docparams.py

Pierre-Sassoulas

The added functional tests look amazing ! I authorized the workflow, let's see how it goes.

Pierre-Sassoulas

Great first merge request @berkersal. Thank you for the great functional tests. I asked for some clarification on the intent of the MR, there seem to be some contradiction between the title and the test cases (and the description did not permit to clarify for me).

pylint/extensions/docparams.py

tests/functional/ext/docparams/raise/missing_raises_doc_required_min_length.py

github-actions · 2025-05-25T19:28:54Z

🤖 Effect of this PR on checked open source code: 🤖

Effect on home-assistant:
The following messages are now emitted:

too-many-lines:
Too many lines in module (1486/1000)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L1
magic-value-comparison:
Consider using a named constant or an enum instead of ''countries''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L651
consider-using-assignment-expr:
Use 'if (domain := split_entity_id(e_or_u)[0]) not in allowed_domains:' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L826
magic-value-comparison:
Consider using a named constant or an enum instead of ''languages''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L974
magic-value-comparison:
Consider using a named constant or an enum instead of ''box''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L1065
magic-value-comparison:
Consider using a named constant or an enum instead of ''min''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L1068
magic-value-comparison:
Consider using a named constant or an enum instead of ''max''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L1068
magic-value-comparison:
Consider using a named constant or an enum instead of ''min''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L1107
magic-value-comparison:
Consider using a named constant or an enum instead of ''max''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/selector.py#L1110
consider-ternary-expression:
Consider rewriting as a ternary expression
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/schema_config_entry_flow.py#L231
unused-argument:
Unused argument 'user_input'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/schema_config_entry_flow.py#L294
protected-access:
Access to a protected member _common_handler of a client class
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/schema_config_entry_flow.py#L365
arguments-differ:
Number of parameters was 7 in 'ConfigFlow.async_create_entry' and is now 3 in overriding 'SchemaConfigFlowHandler.async_create_entry' method
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/schema_config_entry_flow.py#L398
protected-access:
Access to a protected member _common_handler of a client class
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/schema_config_entry_flow.py#L461
arguments-differ:
Number of parameters was 5 in 'FlowHandler.async_create_entry' and is now 3 in overriding 'SchemaOptionsFlowHandler.async_create_entry' method
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/schema_config_entry_flow.py#L466
consider-using-assignment-expr:
Use 'if (entry := registry.async_get(entity_id)):' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/schema_config_entry_flow.py#L491
consider-using-assignment-expr:
Use 'if (state := hass.states.get(entity_id)):' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/helpers/schema_config_entry_flow.py#L494
too-many-instance-attributes:
Too many instance attributes (10/7)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/util/aiohttp.py#L58
too-many-arguments:
Too many arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/util/aiohttp.py#L63
too-many-positional-arguments:
Too many positional arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/util/aiohttp.py#L63
protected-access:
Access to a protected member _value of a client class
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/util/aiohttp.py#L126
consider-using-assignment-expr:
Use 'if (entity := hass.data[DOMAIN]['devices'].get(dev_id)) is not None:' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L51
invalid-overridden-method:
Method 'unique_id' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L76
invalid-overridden-method:
Method 'battery_level' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L81
invalid-overridden-method:
Method 'extra_state_attributes' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L86
invalid-overridden-method:
Method 'location_accuracy' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L91
invalid-overridden-method:
Method 'latitude' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L96
invalid-overridden-method:
Method 'longitude' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L105
invalid-overridden-method:
Method 'location_name' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L114
invalid-overridden-method:
Method 'device_info' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L124
magic-value-comparison:
Consider using a named constant or an enum instead of ''host_name''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/owntracks/device_tracker.py#L127
locally-disabled:
Locally disabling import-outside-toplevel (C0415)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2858
empty-comment:
Line with empty comment
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L984
empty-comment:
Line with empty comment
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2438
empty-comment:
Line with empty comment
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2638
empty-comment:
Line with empty comment
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2643
empty-comment:
Line with empty comment
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2649
empty-comment:
Line with empty comment
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2650
line-too-long:
Line too long (103/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2364
line-too-long:
Line too long (106/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2508
line-too-long:
Line too long (108/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2823
line-too-long:
Line too long (143/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2833
line-too-long:
Line too long (106/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2848
line-too-long:
Line too long (104/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2849
too-many-lines:
Too many lines in module (2864/1000)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1
too-complex:
'_compile_statistics' is too complex. The McCabe rating is 14
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L637
too-complex:
'_reduce_statistics' is too complex. The McCabe rating is 15
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1015
too-complex:
'statistic_during_period' is too complex. The McCabe rating is 18
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1601
too-complex:
'_statistics_during_period_with_session' is too complex. The McCabe rating is 19
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1855
too-complex:
'_sorted_statistics_to_dict' is too complex. The McCabe rating is 12
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2372
consider-ternary-expression:
Consider rewriting as a ternary expression
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L347
consider-using-any-or-all:
for loop could be any(from_unit in converter.VALID_UNITS and to_unit in converter.VALID_UNITS for converter in STATISTIC_UNIT_TO_UNIT_CONVERTER.values())
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L395
too-many-locals:
Too many local variables (20/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L492
consider-using-assignment-expr:
Use 'if (stats := execute_stmt_lambda_element(session, stmt)):' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L509
consider-using-augmented-assign:
Use '%=' to do an augmented assign directly
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L517
consider-using-assignment-expr:
Use 'if (stats := execute_stmt_lambda_element(session, stmt)):' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L530
while-used:
Used while loop
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L582
too-many-locals:
Too many local variables (22/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L637
magic-value-comparison:
Consider using a named constant or an enum instead of '50'.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L699
magic-value-comparison:
Consider using a named constant or an enum instead of '55'.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L710
magic-value-comparison:
Consider using a named constant or an enum instead of '55'.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L718
too-many-branches:
Too many branches (13/12)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L637
too-many-try-statements:
try clause contains 2 statements, expected at most 1
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L774
too-many-arguments:
Too many arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1015
too-many-positional-arguments:
Too many positional arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1015
too-many-locals:
Too many local variables (29/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1015
magic-value-comparison:
Consider using a named constant or an enum instead of ''mean''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1026
magic-value-comparison:
Consider using a named constant or an enum instead of ''min''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1027
magic-value-comparison:
Consider using a named constant or an enum instead of ''max''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1028
magic-value-comparison:
Consider using a named constant or an enum instead of ''last_reset''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1029
magic-value-comparison:
Consider using a named constant or an enum instead of ''state''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1030
magic-value-comparison:
Consider using a named constant or an enum instead of ''sum''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1031
too-many-branches:
Too many branches (14/12)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1015
too-many-arguments:
Too many arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1285
too-many-positional-arguments:
Too many positional arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1285
too-many-locals:
Too many local variables (18/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1285
magic-value-comparison:
Consider using a named constant or an enum instead of ''max''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1298
magic-value-comparison:
Consider using a named constant or an enum instead of ''mean''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1300
magic-value-comparison:
Consider using a named constant or an enum instead of ''min''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1307
consider-using-assignment-expr:
Use 'if not (stats := cast(Sequence[Row[Any]], execute_stmt_lambda_element(session, stmt))):' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1314
magic-value-comparison:
Consider using a named constant or an enum instead of ''max''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1316
magic-value-comparison:
Consider using a named constant or an enum instead of ''mean''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1319
magic-value-comparison:
Consider using a named constant or an enum instead of ''min''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1334
too-many-arguments:
Too many arguments (10/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1339
too-many-positional-arguments:
Too many positional arguments (10/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1339
magic-value-comparison:
Consider using a named constant or an enum instead of ''max''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1393
magic-value-comparison:
Consider using a named constant or an enum instead of ''mean''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1395
consider-using-augmented-assign:
Use '/=' to do an augmented assign directly
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1405
magic-value-comparison:
Consider using a named constant or an enum instead of ''min''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1407
too-many-arguments:
Too many arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1446
too-many-positional-arguments:
Too many positional arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1446
consider-using-assignment-expr:
Use 'if (prev_period := period - Statistics.duration) < oldest_stat:' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1492
too-many-boolean-expressions:
Too many boolean expressions in if statement (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1496
too-many-arguments:
Too many arguments (9/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1537
too-many-positional-arguments:
Too many positional arguments (9/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1537
too-many-arguments:
Too many arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1601
too-many-positional-arguments:
Too many positional arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1601
too-many-locals:
Too many local variables (26/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1601
too-many-boolean-expressions:
Too many boolean expressions in if statement (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1654
consider-using-assignment-expr:
Use 'if (tail_start_time := _last_statistic(session, Statistics, metadata_id)):' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1679
magic-value-comparison:
Consider using a named constant or an enum instead of ''change''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1711
consider-using-assignment-expr:
Use 'if not (convert := _get_statistic_to_display_unit_converter(unit, state_unit, units)):' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1748
too-many-branches:
Too many branches (20/12)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1601
too-many-statements:
Too many statements (61/50)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1601
too-many-arguments:
Too many arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1803
too-many-positional-arguments:
Too many positional arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1803
too-many-locals:
Too many local variables (22/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1803
magic-value-comparison:
Consider using a named constant or an enum instead of ''sum''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1814
magic-value-comparison:
Consider using a named constant or an enum instead of ''sum''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1842
consider-ternary-expression:
Consider rewriting as a ternary expression
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1844
too-many-arguments:
Too many arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1855
too-many-positional-arguments:
Too many positional arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1855
too-many-locals:
Too many local variables (19/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1855
magic-value-comparison:
Consider using a named constant or an enum instead of ''change''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1883
confusing-consecutive-elif:
Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1903
magic-value-comparison:
Consider using a named constant or an enum instead of ''day''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1893
confusing-consecutive-elif:
Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1915
magic-value-comparison:
Consider using a named constant or an enum instead of ''week''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1903
magic-value-comparison:
Consider using a named constant or an enum instead of ''month''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1915
magic-value-comparison:
Consider using a named constant or an enum instead of ''5minute''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1923
magic-value-comparison:
Consider using a named constant or an enum instead of ''day''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1946
magic-value-comparison:
Consider using a named constant or an enum instead of ''week''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1949
magic-value-comparison:
Consider using a named constant or an enum instead of ''month''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1952
magic-value-comparison:
Consider using a named constant or an enum instead of ''change''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1955
too-many-branches:
Too many branches (18/12)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1855
too-many-arguments:
Too many arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1970
too-many-positional-arguments:
Too many positional arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L1970
too-many-arguments:
Too many arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2026
too-many-positional-arguments:
Too many positional arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2026
consider-ternary-expression:
Consider rewriting as a ternary expression
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2045
too-many-arguments:
Too many arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2252
too-many-positional-arguments:
Too many positional arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2252
too-many-arguments:
Too many arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2372
too-many-positional-arguments:
Too many positional arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2372
too-many-locals:
Too many local variables (31/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2372
magic-value-comparison:
Consider using a named constant or an enum instead of ''last_reset_ts''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2409
magic-value-comparison:
Consider using a named constant or an enum instead of ''sum''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2411
too-many-branches:
Too many branches (14/12)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2372
use-implicit-booleaness-not-comparison-to-zero:
"start.minute != 0" can be simplified to "start.minute", if it is strictly an int, as 0 is falsey
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2506
use-implicit-booleaness-not-comparison-to-zero:
"start.second != 0" can be simplified to "start.second", if it is strictly an int, as 0 is falsey
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2506
use-implicit-booleaness-not-comparison-to-zero:
"start.microsecond != 0" can be simplified to "start.microsecond", if it is strictly an int, as 0 is falsey
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2506
magic-value-comparison:
Consider using a named constant or an enum instead of ''last_reset''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2513
unused-argument:
Unused argument 'hass'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2605
suppressed-message:
Suppressed 'import-outside-toplevel' (from line 2858)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/statistics.py#L2858
too-many-arguments:
Too many arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L107
too-many-positional-arguments:
Too many positional arguments (7/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L107
magic-value-comparison:
Consider using a named constant or an enum instead of ''start_time''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L143
magic-value-comparison:
Consider using a named constant or an enum instead of ''end_time''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L143
magic-value-comparison:
Consider using a named constant or an enum instead of ''duration''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L143
magic-value-comparison:
Consider using a named constant or an enum instead of ''offset''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L145
magic-value-comparison:
Consider using a named constant or an enum instead of ''duration''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L145
too-many-arguments:
Too many arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L164
too-many-positional-arguments:
Too many positional arguments (8/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L164
magic-value-comparison:
Consider using a named constant or an enum instead of ''last_reset''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L184
too-many-try-statements:
try clause contains 2 statements, expected at most 1
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L357
too-many-try-statements:
try clause contains 2 statements, expected at most 1
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/recorder/websocket_api.py#L412
magic-value-comparison:
Consider using a named constant or an enum instead of ''tts''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/config_flow.py#L259
magic-value-comparison:
Consider using a named constant or an enum instead of ''vision''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/config_flow.py#L260
line-too-long:
Line too long (124/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L352
line-too-long:
Line too long (111/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L353
line-too-long:
Line too long (103/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L364
line-too-long:
Line too long (138/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L433
magic-value-comparison:
Consider using a named constant or an enum instead of ''gemma''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L324
magic-value-comparison:
Consider using a named constant or an enum instead of ''gemini-2.0-flash-preview-image-generation''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L325
magic-value-comparison:
Consider using a named constant or an enum instead of ''tool_result''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L344
use-implicit-booleaness-not-comparison-to-string:
"chat_content.content == ''" can be simplified to "not chat_content.content", if it is strictly a string, as an empty string is falsey
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L350
redefined-loop-name:
Redefining 'chat_content' from loop (line 343)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L354
magic-value-comparison:
Consider using a named constant or an enum instead of ''user''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L365
invalid-name:
Variable name "generateContentConfig" doesn't conform to snake_case naming style
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L373
too-many-try-statements:
try clause contains 6 statements, expected at most 1
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L428
consider-using-assignment-expr:
Use 'if not (response_parts := chat_response.candidates[0].content.parts):' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L463
no-self-use:
Method could be a function
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/google_generative_ai_conversation/conversation.py#L509
import-error:
Unable to import 'tuya_sharing'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/tuya/event.py#L5
consider-using-assignment-expr:
Use 'if (dpcode := description.key) in device.status:' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/tuya/event.py#L103
too-many-lines:
Too many lines in module (1446/1000)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/tuya/sensor.py#L1
confusing-consecutive-elif:
Consecutive elif with differing indentation level, consider creating a function to separate the inner elif
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/tuya/sensor.py#L1360
invalid-overridden-method:
Method 'native_value' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/tuya/sensor.py#L1401
consider-using-assignment-expr:
Use 'if (value := self.device.status.get(self.entity_description.key)) is None:' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/tuya/sensor.py#L1415
too-many-return-statements:
Too many return statements (10/6)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/tuya/sensor.py#L1401
invalid-overridden-method:
Method 'extra_state_attributes' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/starline/device_tracker.py#L40
invalid-overridden-method:
Method 'battery_level' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/starline/device_tracker.py#L45
invalid-overridden-method:
Method 'location_accuracy' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/starline/device_tracker.py#L50
invalid-overridden-method:
Method 'latitude' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/starline/device_tracker.py#L55
invalid-overridden-method:
Method 'longitude' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/starline/device_tracker.py#L60
consider-using-assignment-expr:
Use 'if (num_previous_rounds := message_history.num_user_messages - 1) >= max_messages:' instead
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/ollama/conversation.py#L307
no-self-use:
Method could be a function
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/ollama/conversation.py#L291
no-self-use:
Method could be a function
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/ollama/conversation.py#L317
import-error:
Unable to import 'quantum_gateway'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/quantum_gateway/device_tracker.py#L5
import-error:
Unable to import 'voluptuous'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/quantum_gateway/device_tracker.py#L7
unused-argument:
Unused argument 'hass'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/quantum_gateway/device_tracker.py#L31
abstract-method:
Method 'get_extra_attributes' is abstract in class 'DeviceScanner' but is not overridden in child class 'QuantumGatewayDeviceScanner'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/quantum_gateway/device_tracker.py#L39
too-many-try-statements:
try clause contains 2 statements, expected at most 1
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/quantum_gateway/device_tracker.py#L50
line-too-long:
Line too long (102/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/reolink/__init__.py#L479
too-many-locals:
Too many local variables (26/15)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/reolink/__init__.py#L359
magic-value-comparison:
Consider using a named constant or an enum instead of ''update''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/reolink/__init__.py#L454
magic-value-comparison:
Consider using a named constant or an enum instead of '3'.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/reolink/__init__.py#L477
too-many-statements:
Too many statements (73/50)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/reolink/__init__.py#L359
unused-variable:
Unused variable 'old_ch'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/reolink/__init__.py#L389
unused-variable:
Unused variable 'old_is_chime'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/reolink/__init__.py#L389
line-too-long:
Line too long (114/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L211
line-too-long:
Line too long (160/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L252
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L63
unexpected-keyword-arg:
Unexpected keyword argument 'name' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L63
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L71
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L71
unexpected-keyword-arg:
Unexpected keyword argument 'entity_category' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L71
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L78
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L78
unexpected-keyword-arg:
Unexpected keyword argument 'entity_category' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L78
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L87
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L87
unexpected-keyword-arg:
Unexpected keyword argument 'entity_category' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L87
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L93
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L100
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L100
unexpected-keyword-arg:
Unexpected keyword argument 'entity_category' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L100
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L106
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L106
unexpected-keyword-arg:
Unexpected keyword argument 'entity_category' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L106
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L115
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L115
unexpected-keyword-arg:
Unexpected keyword argument 'entity_category' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L115
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L124
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L124
unexpected-keyword-arg:
Unexpected keyword argument 'entity_category' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L124
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L130
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L130
unexpected-keyword-arg:
Unexpected keyword argument 'entity_category' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L130
abstract-method:
Method 'turn_off' is abstract in class 'ToggleEntity' but is not overridden in child class 'SmartThingsSwitch'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L235
abstract-method:
Method 'turn_on' is abstract in class 'ToggleEntity' but is not overridden in child class 'SmartThingsSwitch'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L235
too-many-arguments:
Too many arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L240
too-many-positional-arguments:
Too many positional arguments (6/5)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L240
invalid-overridden-method:
Method 'is_on' was expected to be 'method', found it instead as 'property'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L275
abstract-method:
Method 'turn_off' is abstract in class 'ToggleEntity' but is not overridden in child class 'SmartThingsCommandSwitch'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L285
abstract-method:
Method 'turn_on' is abstract in class 'ToggleEntity' but is not overridden in child class 'SmartThingsCommandSwitch'
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/switch.py#L285
line-too-long:
Line too long (147/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L361
line-too-long:
Line too long (130/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L374
line-too-long:
Line too long (104/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L386
line-too-long:
Line too long (130/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L395
too-complex:
'async_migrate_entry' is too complex. The McCabe rating is 15
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L315
magic-value-comparison:
Consider using a named constant or an enum instead of '3'.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L318
magic-value-comparison:
Consider using a named constant or an enum instead of '2'.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L324
magic-value-comparison:
Consider using a named constant or an enum instead of ''binary_sensor''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L327
magic-value-comparison:
Consider using a named constant or an enum instead of ''sensor''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L343
magic-value-comparison:
Consider using a named constant or an enum instead of '' ''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L344
magic-value-comparison:
Consider using a named constant or an enum instead of ''switch''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L393
too-many-return-statements:
Too many return statements (12/6)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L326
magic-value-comparison:
Consider using a named constant or an enum instead of ''burner''.
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L524
redefined-loop-name:
Redefining 'component' from loop (line 521)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/__init__.py#L526
locally-disabled:
Locally disabling too-many-nested-blocks (R1702)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L1109
line-too-long:
Line too long (119/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L1154
line-too-long:
Line too long (121/100)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L1202
too-many-lines:
Too many lines in module (1256/1000)
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L1
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L438
unexpected-keyword-arg:
Unexpected keyword argument 'options' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L438
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L448
unexpected-keyword-arg:
Unexpected keyword argument 'native_unit_of_measurement' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L448
unexpected-keyword-arg:
Unexpected keyword argument 'device_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L448
unexpected-keyword-arg:
Unexpected keyword argument 'state_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L448
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L459
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L459
unexpected-keyword-arg:
Unexpected keyword argument 'native_unit_of_measurement' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L459
unexpected-keyword-arg:
Unexpected keyword argument 'device_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L459
unexpected-keyword-arg:
Unexpected keyword argument 'state_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L459
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L471
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L471
unexpected-keyword-arg:
Unexpected keyword argument 'native_unit_of_measurement' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L471
unexpected-keyword-arg:
Unexpected keyword argument 'state_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L471
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L481
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L481
unexpected-keyword-arg:
Unexpected keyword argument 'native_unit_of_measurement' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L481
unexpected-keyword-arg:
Unexpected keyword argument 'device_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L481
unexpected-keyword-arg:
Unexpected keyword argument 'state_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L481
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L490
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L490
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L496
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L496
unexpected-keyword-arg:
Unexpected keyword argument 'device_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L496
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L504
unexpected-keyword-arg:
Unexpected keyword argument 'native_unit_of_measurement' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L504
unexpected-keyword-arg:
Unexpected keyword argument 'device_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L504
unexpected-keyword-arg:
Unexpected keyword argument 'state_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L504
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L515
unexpected-keyword-arg:
Unexpected keyword argument 'native_unit_of_measurement' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L515
unexpected-keyword-arg:
Unexpected keyword argument 'device_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L515
unexpected-keyword-arg:
Unexpected keyword argument 'state_class' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L515
unexpected-keyword-arg:
Unexpected keyword argument 'key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L526
unexpected-keyword-arg:
Unexpected keyword argument 'translation_key' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L526
unexpected-keyword-arg:
Unexpected keyword argument 'native_unit_of_measurement' in constructor call
https://github.com/home-assistant/core/blob/535d128f8a98827185ace3df2bd8f7761da9a535/homeassistant/components/smartthings/sensor.py#L526
unexpected-ke...

This comment was truncated because GitHub allows only 65536 characters in a comment.

This comment was generated for commit 274a614

Even though visit_functiondef is checking for docstring-min-length, it is not enough. This commit fixes the issue by adding the same check to visit_raise, visit_return and visit_yield

for more information, see https://pre-commit.ci

berkersal · 2025-06-16T10:14:34Z

Sorry that I've reverted some changes accidentally last week, now it should be the correct code

DanielNoord

Awesome thanks!

(cherry picked from commit 7f5e996)

(cherry picked from commit 7f5e996) Co-authored-by: Berker ŞAL <[email protected]>

Pierre-Sassoulas added the False Negative 🦋 No message is emitted but something is wrong with the code label Dec 2, 2024

This comment has been minimized.

Sign in to view

Pierre-Sassoulas requested changes Dec 2, 2024

View reviewed changes

jacobtylerwalls added this to the 4.0.0 milestone Dec 3, 2024

berkersal force-pushed the main branch from 97d992a to c9c1b09 Compare December 6, 2024 15:29

Pierre-Sassoulas reviewed Dec 7, 2024

View reviewed changes

berkersal force-pushed the main branch 5 times, most recently from b794ef3 to c8d7ec9 Compare December 7, 2024 16:07

berkersal force-pushed the main branch from c8d7ec9 to 280c04c Compare December 7, 2024 16:48

berkersal force-pushed the main branch from fc701c4 to 1bac07e Compare January 3, 2025 11:58

berkersal force-pushed the main branch from 1bac07e to 51f61ab Compare January 4, 2025 11:40

This comment has been minimized.

Sign in to view

Pierre-Sassoulas reviewed Jan 4, 2025

View reviewed changes

pylint/extensions/docparams.py Outdated Show resolved Hide resolved

DanielNoord added the Needs take over 🛎️ Orignal implementer went away but the code could be salvaged. label Mar 30, 2025

berkersal force-pushed the main branch from 51f61ab to f05246a Compare May 24, 2025 23:13

Pierre-Sassoulas removed the Needs take over 🛎️ Orignal implementer went away but the code could be salvaged. label May 25, 2025

Pierre-Sassoulas reviewed May 25, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Pierre-Sassoulas requested changes May 25, 2025

View reviewed changes

pylint/extensions/docparams.py Outdated Show resolved Hide resolved

pylint/extensions/docparams.py Outdated Show resolved Hide resolved

tests/functional/ext/docparams/raise/missing_raises_doc_required_min_length.py Show resolved Hide resolved

berkersal force-pushed the main branch from f05246a to 274a614 Compare May 25, 2025 17:15

Pierre-Sassoulas added False Positive 🦟 A message is emitted but nothing is wrong with the code and removed False Negative 🦋 No message is emitted but something is wrong with the code labels May 25, 2025

Pierre-Sassoulas added the backport maintenance/3.3.x label May 25, 2025

Pierre-Sassoulas modified the milestones: 4.0.0, 3.3.8 May 25, 2025

berkersal force-pushed the main branch from 274a614 to 07aaa47 Compare June 4, 2025 17:47

berkersal requested a review from Pierre-Sassoulas June 4, 2025 17:48

berkersal force-pushed the main branch from d7fd351 to 483c66d Compare June 10, 2025 13:22

berkersal and others added 3 commits June 16, 2025 12:13

Respect docstring-min-length in docparams extension

3da2268

Even though visit_functiondef is checking for docstring-min-length, it is not enough. This commit fixes the issue by adding the same check to visit_raise, visit_return and visit_yield

Functional tests for docparams extension docstring-min-length fix

b41cf5e

Changelog for docparams extension docstring-min-length fix

aea598e

berkersal force-pushed the main branch from 483c66d to aea598e Compare June 16, 2025 10:13

[pre-commit.ci] auto fixes from pre-commit.com hooks

d1ad30d

for more information, see https://pre-commit.ci

DanielNoord approved these changes Jun 17, 2025

View reviewed changes

DanielNoord merged commit 7f5e996 into pylint-dev:main Jun 17, 2025
37 of 40 checks passed

DanielNoord temporarily deployed to Backport June 17, 2025 18:13 — with GitHub Actions Inactive

pylint-backport-bot bot pushed a commit that referenced this pull request Jun 17, 2025

Respect docstring-min-length in docparams extension (#10104)

b071be5

(cherry picked from commit 7f5e996)

pylint-backport-bot bot mentioned this pull request Jun 17, 2025

[Backport maintenance/3.3.x] Respect docstring-min-length in docparams extension #10434

Merged

Pierre-Sassoulas pushed a commit that referenced this pull request Jun 17, 2025

Respect docstring-min-length in docparams extension (#10104) (#10434)

6ec71ba

(cherry picked from commit 7f5e996) Co-authored-by: Berker ŞAL <[email protected]>

Uh oh!

Respect docstring-min-length in docparams extension #10104

Respect docstring-min-length in docparams extension #10104

Uh oh!

Conversation

berkersal commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Changes

Description

Uh oh!

codecov bot commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas commented Dec 7, 2024

Uh oh!

berkersal commented Dec 7, 2024

Uh oh!

berkersal commented Jan 3, 2025

Uh oh!

Pierre-Sassoulas commented Jan 3, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 25, 2025

Uh oh!

berkersal commented Jun 16, 2025

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

berkersal commented Dec 2, 2024 •

edited

Loading

codecov bot commented Dec 2, 2024 •

edited

Loading