Skip to content

SBS dispersion propagation fix #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

SBS dispersion propagation fix #515

wants to merge 2 commits into from

Conversation

yangelis
Copy link

Changes:

  • DispersionMomentum as propagable for dpx, dpy
  • Just the necessary code to include dpx_ini etc in the measurement file used for the sbs

Currently only front propagation of dispersion works correctly.

@yangelis yangelis requested a review from a team as a code owner May 23, 2025 14:23
@yangelis yangelis added the Priority: Low Work on this if you have some spare time. label May 23, 2025
@yangelis yangelis marked this pull request as draft May 23, 2025 14:28
@JoschD
Copy link
Member

JoschD commented May 23, 2025

Yooooo! NICE! Thanks a lot for this.
Fork PRs usually don't work on our repos, because they cannot inherit the secrets needed for the github actions. I can quickly make a repo-internal PR

@JoschD JoschD mentioned this pull request May 23, 2025
Merged
@JoschD JoschD moved this to Todo in OMC ToDo 2025 Aug 1, 2025
@JoschD JoschD removed this from OMC ToDo 2025 Aug 1, 2025
@fsoubelet
Copy link
Member

Can we close this @yangelis ?

@yangelis yangelis closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: Low Work on this if you have some spare time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangelis @JoschD @fsoubelet