Fixes for pytest-8.0.0 compatibility

ci/requirements/all-but-dask.yml

@@ -27,7 +27,7 @@ dependencies:
   - pint>=0.22
   - pip
   - pydap
-  - pytest==7.4.*
+  - pytest
   - pytest-cov
   - pytest-env
   - pytest-xdist

ci/requirements/bare-minimum.yml

@@ -6,7 +6,7 @@ dependencies:
   - python=3.9
   - coveralls
   - pip
-  - pytest==7.4.*
+  - pytest
   - pytest-cov
   - pytest-env
   - pytest-xdist

ci/requirements/environment-3.12.yml

@@ -33,7 +33,7 @@ dependencies:
   - pooch
   - pre-commit
   - pydap
-  - pytest==7.4.*
+  - pytest
   - pytest-cov
   - pytest-env
   - pytest-xdist

ci/requirements/environment-windows-3.12.yml

@@ -28,7 +28,7 @@ dependencies:
   - pip
   - pre-commit
   - pydap
-  - pytest==7.4.*
+  - pytest
   - pytest-cov
   - pytest-env
   - pytest-xdist

ci/requirements/environment-windows.yml

@@ -28,7 +28,7 @@ dependencies:
   - pip
   - pre-commit
   - pydap
-  - pytest==7.4.*
+  - pytest
   - pytest-cov
   - pytest-env
   - pytest-xdist

ci/requirements/environment.yml

@@ -34,7 +34,7 @@ dependencies:
   - pre-commit
   - pyarrow # pandas makes a deprecation warning without this, breaking doctests
   - pydap
-  - pytest==7.4.*
+  - pytest
   - pytest-cov
   - pytest-env
   - pytest-xdist

ci/requirements/min-all-deps.yml

@@ -42,7 +42,7 @@ dependencies:
   - pint=0.22
   - pip
   - pydap=3.3
-  - pytest==7.4.*
+  - pytest
   - pytest-cov
   - pytest-env
   - pytest-xdist

xarray/tests/test_dataset.py

@@ -2724,8 +2724,7 @@ def test_drop_index_labels(self) -> None:
         assert_identical(data, actual)
 
         with pytest.raises(ValueError):
-            with pytest.warns(DeprecationWarning):
-                data.drop(["c"], dim="x", errors="wrong_value")  # type: ignore[arg-type]
+            data.drop(["c"], dim="x", errors="wrong_value")  # type: ignore[arg-type]
 
         with pytest.warns(DeprecationWarning):
             actual = data.drop(["a", "b", "c"], "x", errors="ignore")
@@ -3159,8 +3158,7 @@ def test_rename_multiindex(self) -> None:
                 original.rename({"a": "x"})
 
         with pytest.raises(ValueError, match=r"'b' conflicts"):
-            with pytest.warns(UserWarning, match="does not create an index anymore"):
-                original.rename({"a": "b"})
+            original.rename({"a": "b"})
 
     def test_rename_perserve_attrs_encoding(self) -> None:
         # test propagate attrs/encoding to new variable(s) created from Index object

xarray/tests/test_groupby.py

@@ -67,6 +67,8 @@ def test_groupby_dims_property(dataset, recwarn) -> None:
     with pytest.warns(UserWarning, match="The `squeeze` kwarg"):
         assert dataset.groupby("x").dims == dataset.isel(x=1).dims
         assert dataset.groupby("y").dims == dataset.isel(y=1).dims
+    # in pytest-8, pytest.warns() no longer clears all warnings
+    recwarn.clear()
 
     # when squeeze=False, no warning should be raised
     assert tuple(dataset.groupby("x", squeeze=False).dims) == tuple(