Skip to content

Add: Adds a config.yml file for welcome-bot #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 6, 2023

Conversation

nishtha981
Copy link
Contributor

Closes #7685

When a Github user creates their first ever issue or pull request on the xarray repository, the bot would reply to them welcoming them with a friendly message, thanking them for their interest, and point them towards useful links like contributing guidelines.

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Apr 1, 2023
@nishtha981
Copy link
Contributor Author

Hey! @dcherian @TomNicholas
Under which heading in the "what's new.rst" do I put this change under? Internal Changes?

@nishtha981
Copy link
Contributor Author

heyy!
@dcherian @TomNicholas
Could you please review my pr?
Thanks!

Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we test that?
Just merge an hope for the best?

@nishtha981
Copy link
Contributor Author

@headtr1ck
I tried out the bot on a repo of mine.
It worked there.
I then changed the messages on the bot.

image

@nishtha981 nishtha981 requested a review from headtr1ck April 2, 2023 17:19
@headtr1ck headtr1ck added the plan to merge Final call for comments label Apr 2, 2023
@headtr1ck
Copy link
Collaborator

Oh, you can add an entry in whats-new if you want!

@nishtha981
Copy link
Contributor Author

Oh, you can add an entry in whats-new if you want!

Hey! @headtr1ck
I've added the changes to the what's new file.
Please do review it!
Thanks!

Co-authored-by: Michael Niklas  <[email protected]>
Comment on lines 3 to 4
Thanks for opening your first issue here at xarray! Be sure to follow the issue template!
![coding gif](https://media.giphy.com/media/wv1RNuvWMjQ10bzExO/giphy.gif)
Copy link
Contributor

@dcherian dcherian Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thanks for opening your first issue here at xarray! Be sure to follow the issue template!
![coding gif](https://media.giphy.com/media/wv1RNuvWMjQ10bzExO/giphy.gif)
Thanks for opening your first issue here at xarray! Be sure to follow the issue template!
If you have an idea for a solution, we would really welcome a Pull Request with proposed changes.
See the [Contributing Guide](https://docs.xarray.dev/en/latest/contributing.html) for more.
It may take us a while to respond here, but we really value your contribution. Contributors like you
help make xarray better. Thank you!

How about something like this ?

@nishtha981 are there other things that would've been useful to know when you opened your first issue / PR?

I think I prefer no GIF in the issue, that will just distract every time some one reads it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!
I'll remove them and commit these new changes!

Comment on lines 8 to 9
Thank you for opening this pull request! Please check out our contributing guidelines at https://github.com/pydata/xarray/blob/main/CONTRIBUTING.md .
![cat coding](https://media.giphy.com/media/3oKIPnAiaMCws8nOsE/giphy.gif)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thank you for opening this pull request! Please check out our contributing guidelines at https://github.com/pydata/xarray/blob/main/CONTRIBUTING.md .
![cat coding](https://media.giphy.com/media/3oKIPnAiaMCws8nOsE/giphy.gif)
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our [contributing guidelines](http://docs.xarray.dev/en/stable/contributing.html).


# Comment to be posted to on pull requests merged by a first time user
firstPRMergeComment: >
Congratulations on merging your first pull request! We here at xarray are proud of you!
Copy link
Contributor

@dcherian dcherian Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Congratulations on merging your first pull request! We here at xarray are proud of you!
Congratulations on completing your first pull request! Welcome to Xarray!
We are proud of you, and hope to see you again!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, I like the GIF on merge.

The others will be a bit distracting since maintainers open issues and PRs many time.s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sure!
I'll keep the gif on the merge and remove the rest then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@nishtha981 nishtha981 requested a review from dcherian April 3, 2023 16:38
@dcherian dcherian merged commit a0141cd into pydata:main Apr 6, 2023
@dcherian
Copy link
Contributor

dcherian commented Apr 6, 2023

Thanks @nishtha981 this is a great contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add welcome bot?
3 participants