RFC: Add more scipy interpolations methods #5067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meggart
changed the title
meggart
changed the title
meggart
commented
Mar 23, 2021
| "cubic", | ||
| # "next", | ||
| # "previous", | ||
| ] |
There was a problem hiding this comment.
Ideally we would add next and previous to the pandas compat tests as well. However, these interpolation methods are not wrapped by pandas yet, so they currently fail.
There was a problem hiding this comment.
Pandas has this functionality in pad/backfill for fillna() rather than in interpolate. That could be a good method to try for the tests here.
dcherian
reviewed
Mar 23, 2021
| "slinear", | ||
| "quadratic", | ||
| "cubic", | ||
| "previous", |
There was a problem hiding this comment.
we should check that the output matches that from scipy since we can't use pandas for that
Can you add that check here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the list of applicable interpolation methods from scipy's
interp1dto match the methods listed in https://docs.scipy.org/doc/scipy/reference/generated/scipy.interpolate.interp1d.htmlpre-commit run --all-fileswhats-new.rstIs such a small change worth being included in
whats-new.rst?