Skip to content

Fixing non-lazy behavior of sampled+weighted #4668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 16, 2020
Merged

Fixing non-lazy behavior of sampled+weighted #4668

merged 8 commits into from
Dec 16, 2020

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Dec 9, 2020 •
edited
Loading

@jbusecke jbusecke changed the title Added tests with resample+weighted, partially failing Fixing non-lazy behavior of sampled+weighted Dec 9, 2020
@jbusecke jbusecke mentioned this pull request Dec 9, 2020
Closed
mathause
mathause approved these changes Dec 12, 2020
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You added the @requires_cftime to the wrong test.

@jbusecke
Copy link
Contributor Author

Oops. Thanks for catching that. Should be fixed now.

@mathause
Copy link
Collaborator

👍 do you wan't to add a what's new entry? In any case we can merge this in a few days unless someone else has a comment.

@jbusecke
Copy link
Contributor Author

do you wan't to add a what's new entry? In any case we can merge this in a few days unless someone else has a comment.

Not sure. Would you think that this is significant enough? If yes, Id be happy to do it.

@mathause
Copy link
Collaborator

Up to you. Maybe under internal changes.

@keewis
Copy link
Collaborator

keewis commented Dec 14, 2020

I think #4625 is a bug, so "bug fixes" would probably be better

dcherian
dcherian reviewed Dec 14, 2020
View reviewed changes
dcherian
dcherian approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jbusecke

It'd be nice to understand why dask was making a deep copy, but the fix looks good.

@jbusecke
Copy link
Contributor Author

Thanks for all the help! I made the entry to whats-new.rst.

@dcherian dcherian merged commit 778a16e into pydata:master Dec 16, 2020
@keewis keewis mentioned this pull request May 10, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non lazy behavior for weighted average when using resampled data
4 participants
@jbusecke @mathause @keewis @dcherian