Add weighted mean docs. #2012
Merged
Add weighted mean docs. #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Mar 23, 2018
doc/computation.rst
Outdated
| @@ -185,6 +185,12 @@ windowed rolling, convolution, short-time FFT, etc. | |||
|
|
|||
| Because the ``DataArray`` given by ``r.construct('window_dim')`` is a view | |||
| of the original array, it is memory efficient. | |||
| One can also use ``construct`` to compute a weighted mean: | |||
There was a problem hiding this comment.
weighted rolling
And nit: we've used You or We throughout - let's not add another voice
rabernat
approved these changes
Mar 23, 2018
max-sixty
reviewed
Mar 23, 2018
doc/computation.rst
Outdated
| @@ -185,7 +185,7 @@ windowed rolling, convolution, short-time FFT etc. | |||
|
|
|||
| Because the ``DataArray`` given by ``r.construct('window_dim')`` is a view | |||
| of the original array, it is memory efficient. | |||
| One can also use ``construct`` to compute a weighted mean: | |||
| You can also use ``construct`` to compute a weighted mean: | |||
There was a problem hiding this comment.
I do think this should explicitly say weighted rolling mean, may have got lost from #2012 (comment)
max-sixty
approved these changes
Mar 23, 2018
|
Thanks a lot @dcherian ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like @fujiisoup's weighted mean demo in this stack overflow example:
https://stackoverflow.com/questions/48510784/xarray-rolling-mean-with-weights
I thought it'd be a useful addition to the docs on rolling.