facetgrid: unset cmap if colors is specified. #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
Feb 21, 2018
xarray/plot/facetgrid.py
Outdated
| @@ -221,6 +221,14 @@ def map_dataarray(self, func, x, y, **kwargs): | |||
| self : FacetGrid object | |||
|
|
|||
| """ | |||
|
|
|||
| cmapkw = kwargs['cmap'] if 'cmap' in kwargs else None | |||
| colorskw = kwargs['colors'] if 'colors' in kwargs else None | |||
There was a problem hiding this comment.
Use get here, e.g., kwargs.get('cmap').
There was a problem hiding this comment.
Nice, that's a great feature.
dcherian
force-pushed
the
fix/colors-over-cmap
branch
from
99b9cac to
08bdb20
Compare
dcherian
force-pushed
the
fix/colors-over-cmap
branch
from
08bdb20 to
f02b90b
Compare
|
Rebased and squashed. |
fmaussion
approved these changes
Feb 27, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstfor all changes andapi.rstfor new APIThis seemed the cleanest way to fix this. If both
colorsandcmapare specified, raise an error. Ifcolorsis specified andcmapwas None, I set the auto-inferredcmapto None.