Handle new data model in pydap v3.5.5+ #10226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
dcherian
reviewed
Apr 14, 2025
| @@ -131,7 +131,11 @@ def open( | |||
|
|
|||
| def open_store_variable(self, var): | |||
| data = indexing.LazilyIndexedArray(PydapArrayWrapper(var)) | |||
| return Variable(var.dimensions, data, _fix_attributes(var.attributes)) | |||
| return Variable( | |||
There was a problem hiding this comment.
@Mikejmnez does this look right to you?
There was a problem hiding this comment.
Hey @Zeitsperre ! Thanks for pointing me to this @dcherian .
Please see this #10182 , which is ready for review ;)
I have made some change on the pydap end of things (e.g. dims and dimensions). The documentation is not yet updated there.
There was a problem hiding this comment.
Hey @Mikejmnez, this change was working for my use-case, but it looks like the real fix is ever-so-slightly more complicated than my patch here ;). Closing.
There was a problem hiding this comment.
No problems, and thanks a lot @Zeitsperre for the attempted fix :) . Indeed that would have gotten rid of the slashes on dim names +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rstThe latest version of
pydap(v3.5.5) slightly adjust their data model and is incompatible with the current backend handler here.This proposes a backwards-compatible fix for the
dims|dimensionsfield.Changes were introduced in: pydap/pydap#481