feat(types): updated py::capsule type hint to use new types.CapsuleType #5567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.13 adds types.CapsuleType.
This PR changes the type hint for
py::capsule
to the new type.One open question:
Should I only enable
types.CapsuleType
for Python Version>=3.13 or for all versions?Since this only changes type hints/signature it is only in strings and no import is required, so tests still work.
typing.Annotated
is already in use without version guard and requires Python Version >= 3.9.Nanobind falls back to
typing_extensions.CapsuleType
in previous versions.Suggested changelog entry: