Remove obsolete "E501" line in pyproject.toml

[rwgk]

Description

With PR #4912 we removed black:

-# Black, the code formatter, natively supports pre-commit
-- repo: https://github.com/psf/black-pre-commit-mirror
-  rev: "23.10.1" # Keep in sync with blacken-docs
-  hooks:
-  - id: black

So this isn't true anymore:

pybind11/pyproject.toml

Line 72 in d8565ac

"E501", # Line too long (Black is enough)

I tried to remove that line, but it doesn't make a difference, ruff doesn't produce the E501 error. See dummy test case, which doesn't trigger any ruff errors.

It would be nice to see that error, even if we need to fix manually.

@henryiii: Do you happen to know what suppresses the E501?

Suggested changelog entry:

[timohl]

As far as I can see, Ruff does not include E501 by default, so it has to be added to extend-select.
See docs.astral.sh/ruff/configuration for the default settings:
Only "E4", "E7", "E9" are in select but not E5.

[henryiii]

Yes, this got missed when we moved from select to extend-select.

[rwgk]

Thanks for the feedback! — I'll get back to this after #5542 is merged.

[rwgk]

@henryiii We're getting 249 E501 Line too long errors after adding "E5" to extend-select.

This is with the default line-length = 88

Here are all the line lengths > 88:

89 89 89 89 89 89 89 89 89 89 90 90 90 90 90 90 90 90 90 90
90 90 90 90 90 90 91 91 91 91 91 91 91 91 91 91 91 91 91 91
91 91 91 92 92 92 92 92 92 92 92 92 92 92 92 93 93 93 93 93
93 93 93 93 93 94 94 94 94 94 94 94 94 94 94 94 95 95 95 95
95 95 95 95 95 95 95 95 95 95 95 96 96 96 96 96 96 96 96 96
96 96 96 96 96 96 96 97 97 97 97 97 97 97 97 97 97 97 97 97
97 97 97 97 98 98 98 98 98 98 98 98 98 99 99 99 99 99 99 99
99 99 99 99 99 99 99 99 100 100 100 100 100 100 100 100 100 101 101 101
101 101 102 102 102 102 102 102 103 103 103 103 103 103 103 104 104 104 104 104
105 106 106 107 107 107 107 107 107 107 107 108 108 108 109 109 110 111 111 111
113 113 113 114 114 114 114 115 115 115 115 116 116 116 116 116 117 118 119 119
120 121 124 124 124 125 127 129 130 130 131 133 134 140 140 140 142 145 145 146
153 158 158 158 163 163 189 220 221

Where do we want to cut off?

[henryiii]

Ruff format makes these pretty rare, the only times it hits are for things like long strings. I'd say I'd be fine to leave the default (don't enable E5) since we use ruff format. There's a reason it's on in the default selection. :)

[henryiii]

And drop this one.

[rwgk]

Done.

I'd prefer a limit (same as for code), but oh well.

[rwgk]

Ruff format makes these pretty rare, the only times it hits are for things like long strings. I'd say I'd be fine to leave the default (don't enable E5) since we use ruff format. There's a reason it's on in the default selection. :)

Is my understanding correct: Do you want to leave the line-length for long strings unlimited?