ENH: Enhance XMP metadata handling with creation and setter methods #3410
Conversation
Arya-A-Nair
force-pushed
the
feature/xmp-create-method
branch
from
9183c12 to
7129e69
Compare
- Fix missing Dict and List imports in typing - All XMP setter methods are now working correctly - All tests pass except one unrelated remote file test - XmpInformation.create() and all setter methods fully functional - Code follows existing codebase patterns and style
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3410 +/- ##
==========================================
+ Coverage 96.97% 97.03% +0.06%
==========================================
Files 54 54
Lines 9324 9557 +233
Branches 1708 1738 +30
==========================================
+ Hits 9042 9274 +232
Misses 168 168
- Partials 114 115 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add tests for ownerDocument None error conditions (lines 459-465, 484, 506, 535, 564, 597) - Add tests for description element creation paths - Add tests for attribute handling and edge cases - Improve test coverage from 95% to 97% - All XMP functionality thoroughly tested with error conditions and edge cases
|
Thanks for the PR. Besides the coverage: Could we please have proper properties instead of a read-only property and a setter? This is not really pythonic. |
|
@stefan6419846 yeah sure, I understood my mistake. I'll refactor it and ask for review, once done |
Arya-A-Nair
force-pushed
the
feature/xmp-create-method
branch
from
d66f82b to
1abdf04
Compare
|
@stefan6419846 you can take a look at it now |
|
Sorry for the delays - I did not yet have the time to properly review these larger changes again. I hope that I manage to look into this in the next days. |
|
Hey @stefan6419846 can i contribute to some other issue till that time? |
Closes #3394