STY: Tweak PdfWriter #3337
Open
STY: Tweak PdfWriter #3337
+31
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
=======================================
Coverage 96.95% 96.96%
=======================================
Files 55 55
Lines 9341 9343 +2
Branches 1708 1710 +2
=======================================
+ Hits 9057 9059 +2
Misses 169 169
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you please have a look at the coverage? All (new) conditions should be covered be appropriate tests. |
stefan6419846
added
the
needs-test
Co-authored-by: Stefan <[email protected]>
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes including making method insert_blank_page more flexible.