-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add CRN file parser #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CRN file parser #666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I don't understand fully how the test works, with the limited list of dtype included in the DTYPE constant. Would it be safer to specify type for every column?
At first I only spec-ed the dtype for irradiance since that was the one that caused problems in the test, then I added the others that I actually cared about, but yes, better to just specify all of them. Latest commit also works around some pandas versions issues. |
I finally have all of the tests passing. I increased the minimum pandas version to 0.16 so that I could use |
About the non-solar fields: I think it's simpler to return the full CRN file content and let the pvlib user extract the data of interest for their application. |
Works for me. I've found some issues with the |
If there are no further comments, I think this is ready to merge. |
Thanks for the suggestions @mikofski! |
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
file for all changes.Adds a parser for the US Climate Reference Network files available at https://www.ncdc.noaa.gov/crn/qcdatasets.html
The map below shows the locations of these sensors.
Question: what should we do about the columns that pvlib does not use (e.g. precip, soil moisture, surface temp)? I'm keeping them at the moment. I could add a kwarg, but I'd prefer to keep it simple unless there's a good reason to complicate it.