Skip to content

Corrected future warning in solarposition.py #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Conversation

YoannUniKS
Copy link
Contributor

@YoannUniKS YoannUniKS commented Jul 8, 2021

  • corrected code to avoid: "casting datetime64[ns, Europe/Berlin] values to int64 with .astype(...) is deprecated and will raise in a future version. Use .view(...) instead."
  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

- corrected code to avoid: casting datetime64[ns, Europe/Berlin] values to int64 with .astype(...) is deprecated and will raise in a future version. Use .view(...) instead.
@wholmgren wholmgren added this to the 0.9.0 milestone Jul 9, 2021
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YoannUniKS! Feel free to add your name/username to the 0.9.0.rst whats new file or to skip it. I'll merge in a few days unless I hear otherwise.

@cwhanse cwhanse mentioned this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants