Skip to content

Update Toast Notif #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

corlard3y
Copy link
Collaborator

@corlard3y corlard3y commented Jul 11, 2025

Pull Request Template

#2039

Description

  • Problem/Feature:
  • Update Toast Notification

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe): Update Notification

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal -
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Screenshot 2025-07-11 at 11 35 53

Additional Context

  • Had one error in the dev mode sdk link file which i fixed in this PR as well

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Jul 11, 2025 that may be closed by this pull request
@corlard3y corlard3y changed the title update toast notifs Update Toast Notif Jul 11, 2025
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://pushchain.github.io/push-dapp/pr-preview/pr-2040/
on branch gh-pages at 2025-07-11 10:45 UTC

@@ -6,7 +6,7 @@ import path from 'path';
import readline from 'readline';

// import package json
import packageJSON from './package.json' assert { type: 'json' };
import packageJSON from './package.json' with { type: 'json' };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't assert is the proper way to import JSON modules..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👾 Update Notification Component
2 participants