Skip to content

Update to 0.15.0 PureScript #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Update to 0.15.0 PureScript #274

wants to merge 24 commits into from

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #273. Still a WIP. Besides updating the server code, I also updated the client and staging code to 0.15.0.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0 by @)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

}
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed once debug gets added to the package set.

, "web-html"
]
, packages = ./packages.dhall
, sources = [ "src/**/*.purs", "test/**/*.purs" ]
, sources = [ "src/**/*.purs", "config/dev/**/*.purs", "test/**/*.purs" ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should use 3 spago.dhall files: a shared one, one for dev and one for prod?

@mikesol
Copy link

mikesol commented May 1, 2022

This looks really good! I tried to hack at it a bit and spotted that setupIFrame and teardownIFrame are exported from Container.js without being defined there, which may be problematic for esbuild. Is that the bundler you're going to use for the client?

@mikesol
Copy link

mikesol commented May 2, 2022

@JordanMartinez if you want to assign me as a reviewer I can mark the places where I needed to make changes for my dockerized version of trypurescript (the one on try.wags.fm). Some of them will be needed for this PR as well (for example, I hit the esbuild issues with top being a reserved word, etc).

@JordanMartinez
Copy link
Contributor Author

@mikesol This PR will need to update the code to do both #263 and #264.

setupIFrame and teardownIFrame are exported from Container.js without being defined there, which may be problematic for esbuild

Looks like those two functions are defined in client/public/index.html. Since we'll be using SystemJS, I don't think we'll implement the code in the same way as before, so this might be a moot point.

@JordanMartinez
Copy link
Contributor Author

Succeeded by #275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 0.15.0 compiler
2 participants