Skip to content

Use svg favicon with ico fallback #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2020
Merged

Use svg favicon with ico fallback #191

merged 1 commit into from
Aug 22, 2020

Conversation

milesfrain
Copy link
Contributor

There's likely a way to share a single svg file and configure the fill color to reduce code duplication between favicon-black.svg and favicon-white.svg, but that can be tackled in another task.

  • The svg icons look much nicer in browser than support them, especially in the non-active tab:
    • Old: image image
    • New: image image

@milesfrain milesfrain mentioned this pull request Aug 4, 2020
Closed
@thomashoneyman thomashoneyman merged commit 91f3716 into purescript:master Aug 22, 2020
@milesfrain milesfrain deleted the favicon branch August 22, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milesfrain @hdgarrood @thomashoneyman