Skip to content

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #855

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

If you bump the release number in spago.cabal and in the Changelog we can also release this right away 🙂

@JordanMartinez
Copy link
Contributor Author

Done!

@f-f f-f merged commit 41d9c96 into purescript:master Feb 12, 2022
@f-f
Copy link
Member

f-f commented Feb 12, 2022

Thank you! I won't be at a computer for a while, so it'd be great if any of you could run the ./release.sh script to get the release out

@JordanMartinez JordanMartinez deleted the fix-node-args branch February 12, 2022 16:51
@JordanMartinez
Copy link
Contributor Author

I just ran ./release.sh.

@JordanMartinez
Copy link
Contributor Author

@f-f
Copy link
Member

f-f commented Feb 12, 2022

Did you run that on your fork? It needs to be run from this repo - IIRC you should be authorised to push to the repo, but if not I can fix this next time I'm at a keyboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spago run -a '--someFlag' fails to run
3 participants