Print install command to fix missing transitive dependencies #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesfrain
commented
Apr 8, 2021
| @@ -242,3 +242,5 @@ sourceImportsTransitiveDependency transitive = makeMessage $ | |||
| [ "Some of your project files import modules from packages that are not in the direct dependencies of your project." | |||
| , "To fix this error add the following packages to the list of dependencies in your config:" | |||
There was a problem hiding this comment.
Comment related to the unusedDependency block above (must expand due to this github feature gap isaacs/github#284):
It would be nice if we could also offer the same convenience for unused dependencies here with a spago uninstall or spago remove line. I recall uninstall/remove being proposed before, but I can't find the issue for it.
There was a problem hiding this comment.
IIRC it was a thread on slack. I don't think providing a command here is as urgent as with the other error, as this is just a warning and won't fail your build
milesfrain
commented
Apr 8, 2021
colinwahl
reviewed
Apr 8, 2021
milesfrain
commented
Apr 8, 2021
milesfrain
commented
Apr 10, 2021
f-f
approved these changes
Apr 10, 2021
This was referenced Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Prints a
spago installcommand that will likely install missing transitive dependencies.See #769 for context.
Checklist:
README