Topic/benchotron

[ethul]

This PR incorporates benchotron benchmarks and does some reworking of the tests.

[garyb]

Looks like the travis build is failing because benchotron needs updating for psc v0.7.3-compatible-dependencies (-string v0.7.0).

[ethul]

Good catch @garyb. Thanks.

@hdgarrood would you like a PR for this?

[hdgarrood]

I've released a new version of benchotron which should use up-to-date versions of dependencies. Unfortunately, benchotron now uses quickcheck for generating input data, which is not currently stack-safe, so this is probably blocked on purescript/purescript-quickcheck#37 now.

[ethul]

@hdgarrood Thanks for making the 3.0.0 release. Thanks for pointing out purescript/purescript-quickcheck#37.

@garyb What do you think? Since I already have the benchmarks generated, would you prefer I wait for purescript/purescript-quickcheck#37 or just update with benchotron @ 3.0.0?

[garyb]

@hdgarrood Oh sorry, I hadn't realised you'd rebased that.

I'll merge and release now, and then we can get everything up to date :)

[hdgarrood]

Awesome, thanks. I'll release a 3.0.1 which depends on the newest quickcheck.

[ethul]

@hdgarrood Thanks!

[hdgarrood]

Ok, that's done, so if you depend on 3.0.1 then this should work. I guess you could replace zeroArray with \n -> vectorOf n (pure 0).

[ethul]

@hdgarrood Great! Thanks. Yes, that is what I did for the zeroArray

[hdgarrood]

😄 no problem

[ethul]

@garyb Looks like the dependencies update did the trick. What do you think? Are we good to go for this?

[garyb]

Yep, thanks a lot for your work on all this! I'll make a release.

[ethul]

Great, thank you!

On Sunday, August 16, 2015, Gary Burgess [email protected] wrote:

Yep, thanks a lot for your work on all this! I'll make a release.

—
Reply to this email directly or view it on GitHub
#41 (comment)
.