FoldableWithIndex and TraversableWithIndex instances for Cofree #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good stuff! LGTM. |
garyb
approved these changes
Sep 5, 2023
|
Oops, this didn't have a changelog update so I'll add that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds
Foldable f ⇒ FoldableWithIndex Int (Cofree f)andTraversable f ⇒ TraversableWithIndex (Cofree f)to Data.Comonad.Cofree. Indexing is "depth-based" and start at 0, the same way as it currently is for the respectiveFunctor f ⇒ FunctorWithIndex Int (Cofree f). I tested each function in the REPL, but if necessary I will add some tests too to the PR.Checklist: