Allow primary columns without getLink #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
approved these changes
Jun 27, 2019
| @@ -174,7 +174,7 @@ docs = unit # make component { initialState, render } | |||
| , filterLabel: notNull "Product title" | |||
| , sortBy: null | |||
| , style: css {} | |||
| , getLink: _.link | |||
| , getLink: null -- notNull _.link | |||
There was a problem hiding this comment.
Did you mean to uncomment this?
There was a problem hiding this comment.
Doesn't matter too much either way
src/Lumi/Components/Table.purs
Outdated
| primaryColumn = toMaybe self.props.primaryColumn | ||
| primaryColumn = cleanUpNullables <$> toMaybe self.props.primaryColumn | ||
| where | ||
| cleanUpNullables |
There was a problem hiding this comment.
Was there a particular reason not to write this as cleanUpNullables r = r { getLink = toMaybe r.getLink }?
There was a problem hiding this comment.
Ohh, I forgot you could change the record type if the labels have the same names, thanks
| @@ -77,7 +77,7 @@ type TableProps row = | |||
| , filterLabel :: Nullable String | |||
| , sortBy :: Nullable ColumnName | |||
| , style :: R.CSS | |||
| , getLink :: row -> URL | |||
| , getLink :: Nullable (row -> URL) | |||
There was a problem hiding this comment.
Is this Nullable (as opposed to Maybe) because it's still being used from JS?
There was a problem hiding this comment.
I think we've just recently migrated all the JS usage, so this is just matching the existing API until we change them all to Maybes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary columns offer a few features besides row linking, like not being sortable or hideable. This allows the use of these primary column features without entire row linking.