Skip to content
This repository was archived by the owner on Aug 4, 2023. It is now read-only.

Remove deprecated exists #35

Closed
wants to merge 2 commits into from
Closed

Remove deprecated exists #35

wants to merge 2 commits into from

Conversation

sigma-andex
Copy link
Contributor

@sigma-andex sigma-andex commented Apr 13, 2022 •
edited
Loading

Description of the change

Remove exists since it was removed from purescript-node-fs.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@sigma-andex
Copy link
Contributor Author

🏓 @JordanMartinez

JordanMartinez
JordanMartinez suggested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing that Node.FS.Aff only wraps exists and not existsSync. If we drop exists here, then everyone will need to wrap existsSync. Perhaps we can update the Aff wrapper here to be liftEffect <<< existsSync? It reduces the breakage across the ecosystem while still being more correct.

@sigma-andex
Copy link
Contributor Author

Makes sense. Closing this in favour of #36

@sigma-andex sigma-andex deleted the remove-async-exists branch April 13, 2022 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JordanMartinez JordanMartinez JordanMartinez requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigma-andex @JordanMartinez