This repository was archived by the owner on Dec 18, 2020. It is now read-only.
Add safe versions of various functions from Global.Unsafe. #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some concerns about the use of
unsafeEncodeURIComponent
in purescript-form-urlencoded (and potentiallyunsafeDecodeURIComponent
) were raised in purescript-form-urlencoded#12. Thomas Honeyman suggested that safe alternatives should be added to this library; and, considering #16, it seems like this is something people need.As I understand, this has been avoided up to now in order to keep purescript-globals a zero-dependency library. I suppose we need to consider whether the benefit of reducing dependency bloat outweighs the cost; which in some cases (as linked above) is error-prone code, and in other cases is opting out of purescript-globals altogether.
If we simply aren't willing to accept dependencies here, I have created a separate purescript-globals-safe library introducing the
Global.Safe
module that perhaps should be promoted to the purescript or purescript-contrib organizations and published to Pursuit (which I have avoided for now to prevent redundantGlobal.Safe
modules potentially appearing there).Other than that, I would welcome any feedback you might have, even if this won't be merged, so that I can improve purescript-globals-safe. Thanks in advance!