Incorrect syntax highlighting & commenting format for *.css.liquid & *.scss.liquid files

[davelowensohn]

Great package, but I've been experiencing the following:

Syntax highlighting for .css.liquid & .scss.liquid files matches HTML, not CSS. Similarly, commenting via cmd-/ within a .css.liquid or .scss.liquid file inserts an rather than a /* CSS-style comment */.

A similar discussion is happening here: execjosh/atom-file-types#5

[jmcmullen]

+1

[rptrk]

+1

[puranjayjain]

@davelowensohn is the *.css.liquid, *.scss.liquid standard liquid extension? If yes can you give a reference?

[davelowensohn]

@puranjayjain Yes, these are the default naming conventions for stylesheets in Shopify (old and new versions, respectively). Some examples:

• https://github.com/Shopify/skeleton-theme/tree/master/assets
• https://help.shopify.com/themes/development/templates/checkout-scss-liquid

[puranjayjain]

@davelowensohn Great I'll start work on it but it would be great if you can start a pr on that if you can?

[puranjayjain]

@burodepeper assigning this one to you seems to be your domain. 😄

[burodepeper]

@puranjayjain Uhm, that's not how "this" works. It's not polite to assign me to a task without asking me if I want the "job" in the first place. This is al volunteer work, don't forget that.

But on the issue itself, this is related to atom/language-gfm#154 (comment) in the sense that the current structure of the grammar is not suited for what it is intended to do. language-liquid should inject itself (preferably conditionally) in other grammars. That's rather a much more complex task, because it lies at the core of how this package works.

As I've mentioned before: I'm willing to help out (and this issue looks like an interesting challenge), but as I'm not personally invested in Liquid (I've used it exactly once) it doesn't make sense for me to dedicate my limited time and resources on something that comes close to rewriting the grammar.

[puranjayjain]

@burodepeper sorry my bad I'll possibly try to work this issue by this weeks end then If not I'll ask for your help