Skip to content

Pupil v2.4 Release Candidate 1 #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
papr merged 93 commits into from
Sep 15, 2020
Merged

Pupil v2.4 Release Candidate 1 #2012

papr merged 93 commits into from
Sep 15, 2020

Conversation

@papr
Copy link
Contributor

@papr papr commented Sep 15, 2020

No description provided.

Patrick Faion and others added 30 commits February 13, 2020 16:17
Add minimal Pye3D plugin
2b98646
Use EyeModel_V2 and fix EVENT_KEY bug
4bd3db3
Add old debug window logic
772ec4b
@euryalus
Added visualizer for pye3d
572fd09
@euryalus
Added visualizer for new detector3d.
6aba4ac
@euryalus
Added visualizer for new detector3d.
654b71b
@euryalus
Detector is not getting the frame on update and detect. Needed for th…
3a729cd 
…e 3d search.
@euryalus
Refactor
453d788
@ckbaumann
Break reference cycle in ObservableMethodWrapper
ee4be7a
@ckbaumann
Add check for modified method attributes
c64ee74
@ckbaumann
Use fstrings instead of format
e87d7ed
@ckbaumann
Add tests for wrapped method functionality
d9a6ba4
@ckbaumann
Delete useless import
37816d4
@ckbaumann
Move gc fixture into corresponding class
90c1928
@ckbaumann
Fix remove_wrapper() and add corresponding test
a011083
@ckbaumann
Add descriptor that protects wrapper from being replaced
5dc1224
@ckbaumann
Improve error message
d5cac6d
@ckbaumann
Add test for observing methods from parent classes
1a8987a
@pfaion
Merge branch 'master' into pye3d-new
4f53870
@pfaion
Adapt pye3D plugin for pupil v2 changes
689628c
@pfaion
Add eye camera intrinsics
02ed062
@pfaion
Add ui_available property to Plugin base
78461d9 
Often plugins need to know whether the UI exists or now. It does not
exist in __init__ or when the menu was removed before. This property
makes this information available for all plugins.
@pfaion
Expose focal_length property from camera models
a85c69d
@pfaion
Reinit 3D detector on focal length changes
8a43dc5
@pfaion
Properly cleanup and reopen 3D debug window
256c3f4
@pfaion
Save eye intrinsics in recording
6dbd126
@romanroibu
Add parse_version function for creating a comparable version object
96a062f
@romanroibu
Use parse_version to assert and compare version numbers
4cfa854
@pfaion
Remove unused code
ea8f966
@pfaion
Cleanup camera_models log messages
c97ed9e
pfaion and others added 29 commits September 7, 2020 10:38
@pfaion
Clarify logic for reset_model via network message
17948e5
Merge pull request #2005 from pupil-labs/pye3d-reset-via-network
3441ccb 
Allow resetting 3D model via network notification
@pfaion
Add support for offline detection in pye3D
3c8b213
@romanroibu
Fix recording software version string formatting
c2e1f1a
@papr
Merge pull request #2006 from pupil-labs/cu-7yrct6
2b38b30 
Fix recorder crash on version formatting
@papr
Merge v2.3 tag into develop
4b88d57
Merge pull request #1998 from pupil-labs/pye3d
e0ab2c3 
Add pye3d support
@pfaion
Prevent eye window crash from ellipse2Poly issues
9fca8eb 
There was a new error type which could happen here, so I extended to
logging. Additionally the previous error handling was not correct, as we
would still crash when running the code below without `pts` being
computed.
@papr
Merge pull request #2008 from pupil-labs/fix-cv-eye-crash
008d906 
Prevent eye window crash from ellipse2Poly issues
@romanroibu
Add glfwGetMonitorWorkarea function to glfw
e38c164
@romanroibu
Test window position validity with _is_point_within_monitor
29e7685
@romanroibu
Improve format and add comments for window_position_manager.py
355572e
@romanroibu
Update glfwGetMonitorWorkarea to return a named tuple
c1aaa43
@romanroibu
Add glfwGetWindowFrameSize implementation
10bbda1
@romanroibu
Add helper functions to glfw module
a27b750
@romanroibu
Update WindowPositionManager.new_window_position
83b1292 
The new implementation checks if the window's title bar is visible enough to make sure the window can be moved.
@romanroibu
Update launchables to consistenly calculate restored position after t…
522ecba 
…he window is created
@romanroibu
Fix calculating the title bar rect based on the proposed position ins…
2ac144a 
…tead of the actual position
@romanroibu
Increase the minimal title bar area needed to validate restored windo…
6ee3f0c 
…w position
@romanroibu
Only call glViewport if g_pool.camera_render_size is not negative
198f5e5
@romanroibu
Use typing.NamedTuple instead of collections.namedtuple
c32e2b2
@romanroibu
Make rectangle_intersetion function into _Rectangle.intersection method
525aa9d
@romanroibu
Fix loging that ensures g_pool.camera_render_size is non-negative
bf69d69
@romanroibu
Only call glClear in eye on_resize only if not minimized
c3f0ef7
@romanroibu
Use more compact version of NamedTuple definition
8a85c53
@papr
Merge pull request #2007 from pupil-labs/cu-72t9b7
91cb5f1 
Ensure windows are visible when recovering a session
@romanroibu
Fix is_minimized expression in eye.py on_resize
01e1917
@romanroibu
Skip on_resize callback if window is minimized (iconified)
bd95f36
@papr
Merge pull request #2009 from pupil-labs/cu-7ap0kn
6705d98 
Fix GLError when minimizing eye windows on Windows
@papr papr merged commit f4aff3e into master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@papr @euryalus @ckbaumann @pfaion @romanroibu