Support PI headset on/off classifier data #1984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This still needs to be tested on PI recordings with and without the classifier data file (also for multi-part recordings). |
romanroibu
changed the title
papr
suggested changes
Jul 27, 2020
papr
approved these changes
Jul 28, 2020
Avoids numpy ValueError when calling bool(conf_data) implicitly
papr
approved these changes
Aug 20, 2020
Contributor
|
Test recordings: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for integrating the output of the headset on/off classifier data into gaze data confidence for Pupil Invisible recordings. Previously, the confidence of gaze data for such recordings was always set to
1.0. The new implementation sets the confidence to0.0if the classifier output for the given gaze datum is0(which meansoff), or1.0if the output is255(on). If the classifier data file is missing, the implementation falls back to the old implementation of setting the confidence to1.0.