V1.16 fixes #1667
Merged
V1.16 fixes #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when iterating over a filter_multiple() result crashed with a TypeError since sets are not subscriptable
Fixes #1662 - Replaces random 32bit stream with uuids - Handle case were item was not added to storage
ckbaumann
approved these changes
Oct 2, 2019
| random.seed(string) | ||
| unique_id = StorageItem.create_new_unique_id() | ||
| random.setstate(old_state_of_random) | ||
| unique_id = str(uuid.uuid5(UUID_NAMESPACE_PUPIL_LABS, string)) |
Contributor
There was a problem hiding this comment.
Why here 5 and above 4 bytes? Otherwise it looks good!
Contributor
Author
There was a problem hiding this comment.
uuid.uuid4(): Generate a random UUID.
uuid.uuid5(namespace, name): Generate a UUID based on the SHA-1 hash of a namespace identifier (which is a UUID) and a name (which is a string).
In one case we just need a random uuid, in the other case we need to be able to generate a reproducible uuid based on a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.