UVC Backend: Only call update_from_yuv_buffer if yuv subsampling is YUV422 #1620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@papr is there any way of reproducing the issues, such that I can do a before/after validation? |
Contributor
Author
|
@pfaion yes, use a PI headset and connect to Capture. |
romanroibu
approved these changes
Sep 10, 2019
Contributor
|
Turns out this only goes into ghost mode because I'm missing the drivers on Windows. Otherwise this is fine now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the uvc backend did not check the provided YUV subsampling if a YUV buffer was available. pyglui only supports YUV 422 subsampling. If
update_from_yuv_bufferwas called with a different subsampling than YUV 422 it resulted in instabilities and incorrect rendering.The internal conversion from YUV to BGR takes the subsampling into account correctly. Therefore,
update_from_ndarray(frame.bgr)works correctly.This change was not implemented in
Base_Sourcesince not all backends provide theyuv_subsamplingattribute.