Surface tracker - fix GUI bugs #1591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romanroibu
commented
Aug 20, 2019
romanroibu
commented
- Fixes issue (Surface tracker: restore ability to separate overlapping surfaces #1589) where it was impossible to separate overlapping surfaces, because enabling edit mode for one surface would enable it for both, and moving the corner of one surface would move both corners of the overlapping surfaces.
- Fixes issue (Surface tracker: fix edit mode vertices stuck to mouse pointer #1590) where attempting to move a surface's corner would result in that corner being stuck to the mouse pointer.
- Fixes issue where moving the corner of surface A under the "edit" button of surface B would then make it impossible to move that corner elsewhere.
Only consider how close the current pointer position is to the corner if it's not already being moved. If the corner is in the process of being moved, release it on mouse release no mater the distance to the pointer. This avoids situations where moving the corner very fast gets the UI into a state where the corner is stuck to the mouse pointer, but with an offset larger than the distance threshold, making it impossible to fixate.
…ick_menu_buttons and _on_click_marker_toggles This avoids situations where, if the user moves a corner of surface A under the "edit" button of surface B, the corner is then impossible to move, since before corner clicks had lower precedence than menu button toggles.
pfaion
reviewed
Aug 21, 2019
Contributor
pfaion
left a comment
pfaion
left a comment
There was a problem hiding this comment.
Just had a quick look over it as well:
pfaion
approved these changes
Aug 21, 2019
papr
approved these changes
Aug 22, 2019
This was referenced Aug 22, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.