Improve invalid recording errors #1585
Conversation
| all_file_paths = glob.iglob(os.path.join(rec_dir, "*")) | ||
|
|
||
| # TODO: Should this validation be "are there any video files" or are there specific video files? | ||
| if not any(is_video_file(path) for path in all_file_paths): |
There was a problem hiding this comment.
I think the current behavior requires at least one video but I would like to change that to not require anything but an info.csv file with start time and duration keys. See Patrick's implementation for generating wordless lookup tables.
There was a problem hiding this comment.
so what is the correct check here? only the presence of "Start Time" and "Duration Time" in info.csv?
I'm looking at check_for_worldless_recording in update_methods.py but there's no reference to either key. also it seems that this method is generating a world.fake file if a real video file is missing. is_video_file(path) will return True for any video file, including world.fake, so the implementation seems to still be valid.
There was a problem hiding this comment.
Let's talk this through on Thursday.
2 participants
Fixes #1428