Surface Tracker Heatmap Resolution #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like my git history on this branch is not clean. I'll fix this asap. |
papr
reviewed
Aug 14, 2019
papr
reviewed
Aug 14, 2019
pupil_src/shared_modules/surface_tracker/surface_tracker_offline.py
Outdated
Show resolved
Hide resolved
marc-tonsen
force-pushed
the
surface_tracker_hm_resolution
branch
from
c095107 to
4b0538e
Compare
Contributor
Author
|
@papr I incorporated your two comments and cleaned up the git history. |
papr
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no gaze data is available on a surface (either there is none or it is still being mapped in the background) the generated heatmap used to have resolution 1x1px. This PR changes this to always use the resolution implied by the smoothness value.