arrivals_departures/connections: move id column into separate view#66
Draft
arrivals_departures/connections: move id column into separate view#66
Conversation
For the ID, we use frequencies_it, which we compute using a PARTITION BY. Because the latter is prohibitively slow, we move the entire computation into a separate view. Co-Authored-By: Holger Bruch <hb@mfdz.de>
Co-Authored-By: Holger Bruch <hb@mfdz.de>
derhuerst
commented
Nov 4, 2024
Member
Author
derhuerst
left a comment
There was a problem hiding this comment.
Currently, this still causes different sets of arrivals/departures for the (functionally) same query.
git checkout main
# import data...
psql -c 'SELECT route_id, route_short_name, trip_id, trip_headsign, frequencies_it, stop_sequence_consec, t_arrival, t_departure, stop_id, stop_name, station_id FROM arrivals_departures WHERE trip_id = \'171756466\' AND date = \'2022-08-23\' AND t_departure >= \'2022-08-23T06:10+01:00\' AND t_departure <= \'2022-08-23T06:24+01:00\' ORDER BY route_id, trip_id, date, frequencies_it, stop_sequence_consec' | sponge before
git checkout arrs-deps-cons-ids
# import data...
psql -c 'SELECT route_id, route_short_name, trip_id, trip_headsign, frequencies_it, stop_sequence_consec, t_arrival, t_departure, stop_id, stop_name, station_id FROM arrivals_departures_with_ids WHERE trip_id = \'171756466\' AND date = \'2022-08-23\' AND t_departure >= \'2022-08-23T06:10+01:00\' AND t_departure <= \'2022-08-23T06:24+01:00\' ORDER BY route_id, trip_id, date, frequencies_it, stop_sequence_consec' | sponge after
diff before after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, queries on
arrivals_departures&connectionsare slow as soon as there arefrequencies-based rows in there. This is because thefrequencies_it– which is needed forarrival_departure_id/connection_id– calculation uses arow_number()over aPARTITION BY.This PR
arrivals_departures_with_ids/connections_with_ids;arrival_departure_by_arrival_departure_id/connection_by_connection_idto use the new views;