Schedules creation not respecting API RATELIMIT

[PinoOG]

Current Behavior

Hello,

I have noticed that Schedules are not respecting API RATELIMIT.

I have tried a very high value in .env

APP_API_APPLICATION_RATELIMIT=100000
APP_API_CLIENT_RATELIMIT=100000

pino@rr22676:/var/www/pterodactyl# php artisan config:show http

http .............................................................................................................................................
rate_limit ⇁ client_period ..................................................................................................................... 1
rate_limit ⇁ client ....................................................................................................................... 100000
rate_limit ⇁ application_period ................................................................................................................ 1
rate_limit ⇁ application .................................................................................................................. 100000

Expected Behavior

Schedules respecting API RATELIMITS

Steps to Reproduce

1. Create a server on the panel
2. Go to Schedules
3. Create 3 schedules (pretty much with a normal user speed)

You will notice that at 3th schedule creation it will stuck you with 429 Too many attempts

Panel Version

v1.12.0

Wings Version

v1.12.1

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

Is there an existing issue for this?

• I have searched the existing issues before opening this issue. I understand that maintainers may close this issue without communication if I have not provided sufficient information.

[HerrSammyDE]

This is due to the new resource limits that were recently introduced

• https://github.com/pterodactyl/panel/blob/1.0-develop/app/Enum/ResourceLimit.php#L45

In a private fork, I added "return Limit::perMinute(99999999);" above "return match($this) {" so that it works "for now"

[DaneEveritt]

This is intentional — can you let me know the use case for allowing the creation of more schedules than the current per-minute limit? Would bumping it from 2 to 5 resolve your issues? Keep in mind that the API ratelimit is a global limit to requests by user, there are always going to be deeper limits applied to individual resources to avoid spam and malicious behavior.

[PinoOG]

This is intentional — can you let me know the use case for allowing the creation of more schedules than the current per-minute limit? Would bumping it from 2 to 5 resolve your issues? Keep in mind that the API ratelimit is a global limit to requests by user, there are always going to be deeper limits applied to individual resources to avoid spam and malicious behavior.

Hello, in my case, we have a secondary custom panel that executes mass actions towards multiple servers (you can select them). The only actions that fails, are related to schedules. We have around 3 schedules per server and sometimes we change the hour of execution with this custom panel (which uses pterodactyl api)

[HerrSammyDE]

We do something similar here. We also do a lot with the API and encountered the same situation, which is why we set the "custom" limit so that we wouldn't have any problems for the time being

[DaneEveritt]

@PinoOG @HerrSammyDE do either of you have a suggested updated limit that would resolve this for you and not needlessly open up schedules to rate limiting abuse?

[PinoOG]

Hello, I think this is a sort of situation which depends on the end user needs. Wouldnt be possible to specify limits in the .env?

@PinoOG @HerrSammyDE do either of you have a suggested updated limit that would resolve this for you and not needlessly open up schedules to rate limiting abuse?