Skip to content

Conversation

@sr-tream
Copy link

Add filter to be able to show info only for maximized windows.

settings screenshot

Copy link

@amorozov amorozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the pure Plasma (=not Latte) environment it behaves exactly as I expected:

when a window is not maximized, activity information or fallback is displayed.

I haven't tested it with Latte-Dock yet.

Maybe the only suggestion is to preserve space when activity information is not shown and fallback is empty. That way the applets right of the window-title applet would preserve their positions when the active window is maximized/unmaximized.

Also the text of the label in the config/main.xml needs a minor adjustment.

I would also suggest to include "resolves #33" to the PR title

<label>If true, it shows window information only from the current screen</label>
</entry>
<entry name="filterByMaximized" type="Bool">
<label>If true it only shows the app menu if the current active window is maximized</label>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely, not "app menu" but "app title"

@sr-tream sr-tream changed the title Add filter by maximized window Add filter by maximized window (resolves #33) Dec 5, 2022
@sr-tream
Copy link
Author

sr-tream commented Dec 5, 2022

@amorozov

Maybe the only suggestion is to preserve space when activity information is not shown and fallback is empty.

It must work without my PR, like when no any windows present (e.g. after new session started)

Copy link

@amorozov amorozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants