Fix stringio content length #7000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Session.request() docstring to match requests.request() - Changed 'How long to wait' to 'How many seconds to wait' - Fixes inconsistency in timeout documentation Fixes psf#6813
- Add special handling for io.StringIO in super_len() function - Calculate byte length by encoding StringIO content as UTF-8 - Preserve stream position to avoid surprising users - Fixes incorrect Content-Length header when StringIO contains multi-byte UTF-8 characters
- Test multi-byte UTF-8 characters (💩, 🚀, 🎉) - Test position preservation after super_len call - Test partial read scenarios - Test PreparedRequest Content-Length header - Test consistency with str and bytes behavior - All tests verify correct byte-length calculation
- Expand compressed logic into clearer if/else blocks - Add explanatory comment for remaining bytes calculation - Maintain same functionality with better code structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(utils): correct Content-Length for io.StringIO bodies (#6917)