Reduce overhead of Response.ok
#6989
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time `ok` is used it feels like it should be essentially free, but it's not as it goes through `raise_for_status` which does a bunch of preparatory work to manage the reason and check for the two main error categories separately. Reduce `ok` to just check for what it says it does in the first line. Also makes the behaviour consistent with the docstring: before this change `ok` would return `True` if the status code is 600 or above (which some API providers are known to do e.g. Shopify can return 783[^1], LinkedIn has been known to return 999[^2]. However for that reason it is, technically, a breaking change. [^1]: https://shopify.dev/docs/api/usage/response-codes [^2]: https://stackoverflow.com/questions/27231113/999-error-code-on-head-request-to-linkedin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time
okis used it feels like it should be essentially free, but it's not as it goes throughraise_for_statuswhich does a bunch of preparatory work to manage the reason and check for the two main error categories separately.Reduce
okto just check for what it says it does in the first line.Also makes the behaviour consistent with the docstring: before this change
okwould returnTrueif the status code is 600 or above (which some API providers are known to do e.g. Shopify can return 7831, LinkedIn has been known to return 9992. However for that reason it is, technically, a breaking change.Footnotes
https://shopify.dev/docs/api/usage/response-codes ↩
https://stackoverflow.com/questions/27231113/999-error-code-on-head-request-to-linkedin ↩