Fix Build-PSBuildMarkdown + Lint Fixes #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HeyItsGilbert I just realized this is still pending a review. Was this not a part of what was published to the gallery on April 1st in v0.7.1? |
|
I guess not? I'll check when I get to my computer. |
HeyItsGilbert
changed the title
tablackburn
approved these changes
Jul 29, 2025
…and improve parameter formatting * Updated `[cmdletbinding()]` to `[CmdletBinding()]` for consistency. * Enhanced readability by aligning parameter assignments in `$newMDParams`. * Added new words to `cspell.json` for better spell checking.
* Migrate `ScriptAnalyzerSettings.psd1` to `tests` directory and update paths. * Enhance task definitions in `psakeFile.ps1` for better readability and consistency. * Add new exclusion rule for `PSUseApprovedVerbs` in the script analysis settings.
…andling and suppress warnings * Added suppression attributes for unused parameters in `Publish-PSBuildModule` and `Test-PSBuildPester`. * Enhanced `CmdletBinding` attribute casing for consistency. * Refined parameter validation logic for better clarity and maintainability.
…ate changelog * Remove extra item from `New-MarkdownHelp` splat to prevent failure with `$PSBPreference.Docs.Overwrite = $true` * Clean up failing Script Analyzer settings and relocate the configuration file.
…hance psake file * Introduced two new launch configurations for debugging PowerShell scripts in VSCode. * Updated `psakeFile.ps1` to correct property casing and added functionality to control documentation overwrite behavior. * Enhanced tests to verify the documentation overwrite feature.
* Build tests now run in TempDir * TestModule moved into fixtures folder. * Added test for docs
…cation` * Ensures proper stack management for directory changes in tests. * Improves cleanup in `AfterAll` by restoring the previous location.
* Introduced a new `DotSource.psm1` file to facilitate testing of dot-sourced public functions. * This file includes logic to import both public and private functions for comprehensive testing.
* Removed conditional logic for setting `$script:testModuleOutputPath`. * Ensured output path is consistently set relative to the test module source. * Updated `Start-Job` script block declaration for consistency.
… consistency * Standardize function declaration to lowercase in `Get-HelloWorld.ps1`. * Update module import path in `psakeFile.ps1` to use `$global:PSBOutput`. * Clean up unnecessary `Set-Location` commands in test setup. * Ensure output paths are correctly handled for better compatibility.
|
After reviewing this again, I'm deciding to close this and I'll be fixing things in smaller batches. This got out of control way too fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New-MarkdownHelpsplat that would result in a failurewhen using
$PSBPreference.Docs.Overwrite = $trueDescription
There was an extra item being added to the hashtable. This resolves that.
This also addresses several scriptanalyzer warnings.
Related Issue
n\a
Motivation and Context
This fixes a failure scenario with the new Overwrite feature.
How Has This Been Tested?
Checklist: